java-spring-web icon indicating copy to clipboard operation
java-spring-web copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

Add Spring web operation name handler

Open zouyx opened this issue 4 years ago • 7 comments

1.Support Spring RequestMapping 2.HandlerUtils.requestMapping，if use .path()can not get anything when use @Requestmapping so change to value()

zouyx avatar Dec 14 '20 10:12 zouyx

Hi,

Thanks for the contribution.

Can you please explain the rationale behind these changes?

geoand avatar Dec 14 '20 16:12 geoand

Hi,

Thanks for the contribution.

Can you please explain the rationale behind these changes?

Relate to #115 which can not run travis CI.

Just recreate it.

zouyx avatar Dec 15 '20 02:12 zouyx

I see thanks.

Could you please add a test as was requested in the original PR?

geoand avatar Dec 15 '20 06:12 geoand

I see thanks.

Could you please add a test as was requested in the original PR?

I think will add it in this few day

zouyx avatar Dec 15 '20 08:12 zouyx

@zouyx not sure I understand this PR correctly. Is this about changing the operation name to be something more meaningful than GET?

zeitlinger avatar Apr 15 '21 09:04 zeitlinger

@zouyx not sure I understand this PR correctly. Is this about changing the operation name to be something more meaningful than GET?

yes, you are right. because it can not get anything when use @Requestmapping

zouyx avatar Apr 17 '21 16:04 zouyx

Fixes #143

zeitlinger avatar Apr 19 '21 09:04 zeitlinger