java-spring-cloud icon indicating copy to clipboard operation
java-spring-cloud copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

`uber-trace-id` from incoming request overwrites client span in spring cloud gateway tracing

Open rafis opened this issue 2 years ago • 0 comments

Client span is generated here:

https://github.com/opentracing-contrib/java-spring-cloud/blob/8a865d560bf42b4bce839ba9a0977aecff3a4073/instrument-starters/opentracing-spring-cloud-gateway-starter/src/main/java/io/opentracing/contrib/spring/cloud/gateway/TraceRequestHttpHeadersFilter.java#L55-L60

Next we try to inject this span into Http Headers of inner request:

https://github.com/opentracing-contrib/java-spring-cloud/blob/8a865d560bf42b4bce839ba9a0977aecff3a4073/instrument-starters/opentracing-spring-cloud-gateway-starter/src/main/java/io/opentracing/contrib/spring/cloud/gateway/TraceRequestHttpHeadersFilter.java#L65-L70

But if the incoming request to Spring Cloud Gateway had it own uber-trace-id header this will overwrite what we just tried to do. Is it a bug?

rafis avatar Jan 23 '23 11:01 rafis