java-spring-cloud icon indicating copy to clipboard operation
java-spring-cloud copied to clipboard

Fix websocket autoconfig startup failure caused by Spring Messaging 5.3.2

Open countableSet opened this issue 4 years ago • 5 comments

  • Replace usage of WebSocketMessageBrokerConfigurationSupport to access the client inbound/outbound channels with the beans directly since there are no factories or decorators to customize these channels.
  • ChannelInterceptorAdapter deprecation warning Deprecated as of 5.0.7 ChannelInterceptor has default methods (made possible by a Java 8 baseline) and can be implemented directly without the need for this no-op adapter. Replaced with the suggested action.
  • AbstractWebSocketMessageBrokerConfigurer deprecation warning Deprecated as of 5.0 in favor of simply using WebSocketMessageBrokerConfigurer which has default methods, made possible by a Java 8 baseline.. Replaced with the suggested action.

relates to issue #308

countableSet avatar Jan 20 '21 19:01 countableSet

Hi @countableSet , what's the status of this one? I see there are failed tests, so I guess that's why the PR can't be merged?

QBrute avatar Feb 03 '21 11:02 QBrute

hi @MaxMega 👋🏻 master was having some issues at the time (https://travis-ci.org/github/opentracing-contrib/java-spring-cloud/jobs/755557498). It looked like the same error in this pr as in master. So still waiting on that to be fixed before running the tests again. Not sure why this pr can't be merged. I think the maintainers haven't looked at it yet?

countableSet avatar Feb 03 '21 17:02 countableSet

Hi @countableSet sorry that I'm replying so late. It seems that the error is caused by io.opentracing.contrib:opentracing-spring-cloud-parent:pom:0.5.8-SNAPSHOT not being found.

There is a Version 0.5.8, but it's not marked as SNAPSHOT, so maybe that's the problem here. https://search.maven.org/artifact/io.opentracing.contrib/opentracing-spring-cloud-parent/0.5.8/pom

QBrute avatar Feb 14 '21 13:02 QBrute

Looks like this https://github.com/opentracing-contrib/java-spring-cloud/pull/317 fixes the build issue.

countableSet avatar Feb 24 '21 00:02 countableSet

Can we get this PR merged?

dogukancagatay avatar Oct 11 '21 20:10 dogukancagatay