java-kafka-client icon indicating copy to clipboard operation
java-kafka-client copied to clipboard

Update to Kafka 3.0.0

Open scholzj opened this issue 4 years ago • 7 comments
trafficstars

Kafka 3.0.0 is a major release and as such it does some breaking changes such as removes some old methods which were deprecated before and adds new methods etc. This PR updates the tracing support for Kafka clients to use Kafka 3.0.

Apart form removing some removed methods and adding some new, the Embedded Kafka cluster from Spring does not support Kafka 3.0.0 yet. So I replaced it with the Embedded Kafka Cluster which is part of Apache Kafka itself. This should make the tests less dependent on Spring Kafka.

It would be great if this could get reviewed and if we can have a new release to use with Kafka 3.0.0.

scholzj avatar Oct 05 '21 17:10 scholzj

Any chance someone can look at this?

scholzj avatar Oct 12 '21 12:10 scholzj

Any updates on this?

hsargsyan avatar May 06 '22 14:05 hsargsyan

Interested in this PR too. Any timescales for new version?

jondey avatar May 12 '22 20:05 jondey

To support Kafka 3.2.x you need to add a new methods in TracingKafkaConsumer ad make a new PR.

  @Override
  public void enforceRebalance(String s) {

  }
  

moustafa-zein avatar Aug 21 '22 08:08 moustafa-zein

I was able to get this working in my fork with the Kafka 3.2.1 client, and I have tested it with Jaeger and Confluent Platform 7.2.1. The work is here: https://github.com/bashburn/java-kafka-client which I forked from this fork. Let me know, and I can try to add it here, or create a new PR if needed.

solo-seven avatar Aug 30 '22 05:08 solo-seven

Can this be merged ?

kdsundhiya avatar Nov 23 '22 11:11 kdsundhiya

I created a new PR based on my update to the libraries. It is PR #101 if we want to close this one and look at that one.

solo-seven avatar Nov 23 '22 13:11 solo-seven