java-jdbc icon indicating copy to clipboard operation
java-jdbc copied to clipboard

Implements equals method

Open quaff opened this issue 4 years ago • 4 comments

Fix https://github.com/opentracing-contrib/java-jdbc/issues/83

quaff avatar Sep 14 '20 09:09 quaff

Pull Request Test Coverage Report for Build 311

  • 0 of 43 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.06%) to 48.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/TracingDataSource.java 0 7 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingCallableStatement.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingPreparedStatement.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingStatement.java 0 9 0.0%
<!-- Total: 0 43
Totals Coverage Status
Change from base Build 310: -2.06%
Covered Lines: 506
Relevant Lines: 1049

💛 - Coveralls

coveralls avatar Sep 14 '20 09:09 coveralls

As this doesn't use the trick mentioned in #83 to get through the WrapperProxy/Proxy objects, can you explain how this fixes the problem? Did you test with debugging output and ever get a 'true' result (where the WrapperProxy is used)? No tested, you should provide a minimal test case.

quaff avatar Sep 15 '20 00:09 quaff

@randallt WrapperProxy added, but I think It should be done by WrapperProxy self.

quaff avatar Sep 15 '20 00:09 quaff

@randallt Could you provide a test case?

quaff avatar Sep 21 '20 00:09 quaff