go-stdlib icon indicating copy to clipboard operation
go-stdlib copied to clipboard

Add "net/rpc" and `database/sql` support during GSoC 2017

Open starsdeep opened this issue 8 years ago • 6 comments

Currently, instrumentation is just provided for net/http. Instrumentation for net/rpc and database/sqlseems also worth doing.

I am a master who want to apply GSoC 2017, I 'd like to implement the instrumentation for net/rpc or database/sql as my GSoC project.

cc @pritianka

starsdeep avatar Feb 04 '17 06:02 starsdeep

ref https://github.com/opentracing/opentracing-go/issues/132

starsdeep avatar Feb 04 '17 06:02 starsdeep

Naively, I'd vote for database/sql over net/http for sure. That said, the problem with the database package is that there's no support for Go Context, and thus it's almost impossible to find a parent SpanContext.

bhs avatar Feb 04 '17 21:02 bhs

Since 1.8 it supports

noxiouz avatar Feb 04 '17 23:02 noxiouz

@noxiouz ah, that's great. I was looking at https://golang.org/pkg/database/sql/ and forgot it's still 1.7. In that case, database/sql SGTM. :)

bhs avatar Feb 04 '17 23:02 bhs

IMOnet/http/cgi and net/http/fcgi instrumentation is also worth doing. A lot of existing system still use CGI.

zhouheng92 avatar Apr 01 '17 02:04 zhouheng92

Will OpenTracing participate GSoC this year? Seem there is no OpenTracing related ideas in the cncf ideas list for GSoC 2018(see https://github.com/cncf/soc)

cc @pritianka

starsdeep avatar Feb 11 '18 04:02 starsdeep