OpenTomb icon indicating copy to clipboard operation
OpenTomb copied to clipboard

CDAUDIO.WAD Not Implemented ?

Open ghost opened this issue 6 years ago • 10 comments

I created a cdaudio.wad for tr1 with basic audio loaded for level 1, but after rewrite the soundtrack load method of tr1 to load wad, https://github.com/opentomb/OpenTomb/blob/dee5090c0636ef25138a1908ea4a817e2da66b5c/scripts/audio/soundtrack.lua#L720 i have an error in log in-game: "StreamPlay: CANCEL, wrong track index or broken script." but all will fine in script and name is correct !

ghost avatar Aug 25 '18 16:08 ghost

It's not enough to change just that line. You need to change path as well and function return value too. By default the script uses individual files for each audio track.

vvs- avatar Aug 25 '18 17:08 vvs-

that have no sense because method are defined to load .ogg, cdaudio.wad or .wav but need to change path and return ? that break all the function, why define wad if the script cant load the cdaudio.wad itself ?

ghost avatar Aug 26 '18 11:08 ghost

The engine itself supports these formats, but apparently there were no efforts to make configuration flexible. I'd remind that OT is of pre-alpha quality with the only developer who put it on hold recently.

vvs- avatar Aug 26 '18 13:08 vvs-

Sorry, i see that is an alpha and the script (lua) have created but not updated (or just for tr3 new audio), Please, can you add tag to this issue ? this function need to be updated for tr3.

ghost avatar Aug 27 '18 06:08 ghost

There is a temporary solution in https://github.com/opentomb/OpenTomb/issues/347#issuecomment-244590271

vvs- avatar Aug 27 '18 10:08 vvs-

thanks, but temporary solution give the same error :x ps: the cdaudio not have all sound into it.

ghost avatar Aug 27 '18 15:08 ghost

What SHA-1 hash your cdaudio.wad file has? It should be a80a34748f400affe0f4a18dc347a7b85e4226e5, for TR3 that is. If you have some other file it might not work at all.

P.S. BTW there is another sound bug #538 introduced recently which prevents most tracks from playing.

vvs- avatar Aug 27 '18 17:08 vvs-

i use the tr3 audio.wad from gog games, and file in as tr1 mp3 converted to ogg. and i not have the same sha-1 (found with 7zip)

ghost avatar Aug 28 '18 07:08 ghost

hmm need to change how .WAD work for loading, the SHA-1 is really a problem for level creator because if you want more than 128 audio (for big level/game) the SHA-1 cant be a80a34748f400affe0f4a18dc347a7b85e4226e5

ghost avatar Jun 08 '19 13:06 ghost

No, there is no hardcoded check that files have a particular hash. That was just a simple way for me to verify that your file was genuine, i.e. it should have the same hash if it was from TR3 CD. And if that's different then that particular file might have been corrupted. There is no other way to verify the integrity of some file from unknown source.

OT should work with original .WAD, but it's a moot point right now, because audio support is severely broken in the current version.

vvs- avatar Jun 08 '19 15:06 vvs-