opentok-react icon indicating copy to clipboard operation
opentok-react copied to clipboard

Published 20 hours ago • verified publisher icon opentok

Fix Subscriber not supporting insertDefaultUI=false

Open kingdamo opened this issue 5 years ago • 5 comments

Fixed issue #38 so that the subscriber doesn't break when using insertDefaultUI=false

kingdamo avatar Apr 01 '19 04:04 kingdamo

I also added a test to ensure it doesn't break in the future.

kingdamo avatar Apr 01 '19 04:04 kingdamo

Thanks @kingdamo. I'll test this out shortly and update you.

msach22 avatar Apr 09 '19 23:04 msach22

Hi @msach22, could you please complete a review on this PR please.

kingdamo avatar Nov 22 '19 00:11 kingdamo

We've released an update to OpenTok React that allows you to style the containers. Would this help your use case? https://github.com/opentok/opentok-react/pull/99

msach22 avatar Mar 20 '20 17:03 msach22

@msach22 since the official OpenTok JS API supports passing the insertDefaultUI property, I think this change should still be deemed valid. I'm also running into this issue so I would very much appreciate it if you could review this PR shortly. Thanks in advance!

nielsdB97 avatar Apr 05 '20 19:04 nielsdB97