opentok-node
opentok-node copied to clipboard
Added multiArchiveTag to startArchive
What is this PR doing?
This updates startArchive to accept in the multiArchiveTag parameter.
How should this be manually tested?
opentok.startArchive(
sessionId,
{
name: 'My awesome session',
multiArchiveTag: 'tagging this session',
},
(err, archive) => {
if (err) {
console.err(err);
return;
}
console.log(archive);
);
What are the relevant tickets?
@jeffswartz , I was unable to find the merge conflict. Could it be that changing the base resolved it?
multiBroadcastTag was not part of the ticket. @pardel is that part of a different ticket?
@jeffswartz I'm not sure where to add the property to the class. I did check for this first and did not see a need to add it since the code is composing the class props from the properties passed in:
function Archive(config, properties) {
var hasProp = {}.hasOwnProperty;
var id = properties.id;
var key;
for (key in properties) {
if (hasProp.call(properties, key)) {
this[key] = properties[key];
}
}
// ... snip
}
I did add the property to the docs.
Also holding off on bumping the rev since I have another PR waiting to merge.
@jeffswartz I also added multiBroadcastTag as well