opentok-node icon indicating copy to clipboard operation
opentok-node copied to clipboard

Added multiArchiveTag to startArchive

Open manchuck opened this issue 3 years ago • 3 comments

What is this PR doing?

This updates startArchive to accept in the multiArchiveTag parameter.

How should this be manually tested?

opentok.startArchive(
    sessionId, 
    {
        name: 'My awesome session',
        multiArchiveTag: 'tagging this session',
    },
    (err, archive) => {
        if (err) {
            console.err(err);
            return;
        }

        console.log(archive);
);

What are the relevant tickets?

DEVX-6489

manchuck avatar Sep 09 '22 19:09 manchuck

@jeffswartz , I was unable to find the merge conflict. Could it be that changing the base resolved it?

multiBroadcastTag was not part of the ticket. @pardel is that part of a different ticket?

@jeffswartz I'm not sure where to add the property to the class. I did check for this first and did not see a need to add it since the code is composing the class props from the properties passed in:

function Archive(config, properties) {
  var hasProp = {}.hasOwnProperty;
  var id = properties.id;
  var key;

  for (key in properties) {
    if (hasProp.call(properties, key)) {
      this[key] = properties[key];
    }
  }
  // ... snip
}

I did add the property to the docs.

manchuck avatar Oct 03 '22 15:10 manchuck

Also holding off on bumping the rev since I have another PR waiting to merge.

manchuck avatar Oct 03 '22 15:10 manchuck

@jeffswartz I also added multiBroadcastTag as well

manchuck avatar Oct 12 '22 14:10 manchuck