opentok-android-sdk-samples icon indicating copy to clipboard operation
opentok-android-sdk-samples copied to clipboard

Size of SDK has doubled

Open danmajercak opened this issue 1 year ago • 20 comments

Describe the bug Since opentok-android-sdk 2.25.2, the size of sdk has doubled compared to previous version Was that on purpose? What has changed tha size has grown so much?

Screenshots

Screenshot 2023-08-09 at 10 06 04 Screenshot 2023-08-09 at 10 06 14

danmajercak avatar Aug 09 '23 08:08 danmajercak

@danmajercak, the size of the SDK grew due to support for the Media Processor APIs, which was introduced as a beta feature in Android SDK 2.25.3.

v-kpheng avatar Aug 09 '23 21:08 v-kpheng

Does it have to be part of the original sdk? We currently do not want to use this beta feature. But increasing the size of sdk is a blocker for us. Couldn't it be created as a separate dependency and clients who would be interested in this feature would add it?

danmajercak avatar Aug 10 '23 08:08 danmajercak

I saw that 2.25.2 also grew without the beta functionality announcement.

emartynov avatar Aug 10 '23 09:08 emartynov

@danmajercak @emartynov as @v-kpheng mentioned, the SDK grew only due to Media Processor APIs, which provides Background Blur and video/audio custom transformers to publisher's media stream. Even though it was only introduced as a beta feature in Android SDK 2.25.3, it was already part of 2.25.2.

We are working in a solution to provide Media Processor APIs as an additional dependency, but there is no ETA for it at the moment.

Meanwhile, if the size increase is a blocker, I ask to remain with v2.25.1 until further notice

goncalocostamendes avatar Aug 16 '23 18:08 goncalocostamendes

is there any way to exclude this Media Processor API, size of sdk too big

wlTrunks avatar Sep 21 '23 08:09 wlTrunks

@wlTrunks at the moment, there isn't. I would ask you to remain with v2.25.1. We are working on providing Media Processor functionalities as a plugin that you can add to the SDK, but we have not finalise it yet

goncalocostamendes avatar Sep 21 '23 11:09 goncalocostamendes

Just wanted to share an update. We'll work with product on this. Hope we can deliver this in Q1. I'll share a link to the internal ticket once it's created.

v-kpheng avatar Oct 03 '23 16:10 v-kpheng

We're tracking this internally: https://jira.vonage.com/browse/VPF-499.

v-kpheng avatar Oct 03 '23 16:10 v-kpheng

any solution or workaround to reduce the sdk size? I build a project that import com.opentok.android:opentok-android-sdk:2.25.2

the apk size is larger than 100MB so I use "analyze apk" from android studio and it shows libopentok.so is about 40MB(in x86_64)

I enabled ProGuard but no help.

Can the sdk size be reduced?

libopentok_so

ntustzeus avatar Nov 13 '23 10:11 ntustzeus

@ntustzeus unfortunately there is no workaround to reduce the SDK size. I would ask you to remain with v2.25.1 if possible where the size is around half of v2.25.2.

The size has increased on v2.25.2 because we introduced Media Processor functionalities such as Background Blur and Background Replacement. Since the size is an issue for multiple costumers, we are working on providing Media Processor functionalities as a plugin that can be added to the SDK or not.

We're tracking this internally: https://jira.vonage.com/browse/VPF-499. We expect to have it solved by Q1 2024.

goncalocostamendes avatar Nov 13 '23 10:11 goncalocostamendes

@goncalocostamendes Is there a workaround for the size right now in the latest versions? v2.25.1 is unusable because it has the issue with the disconnect events being late 20-30secs causing our users sessions to get messed up if they log out and log in to quickly?

AlexMoumou avatar Feb 12 '24 10:02 AlexMoumou

@AlexMoumou the solution to this problem is on the final stage of development. It should be released in the following weeks

goncalocostamendes avatar Feb 13 '24 11:02 goncalocostamendes

@goncalocostamendes any updates on this issue?

omaiborodahj avatar Apr 29 '24 11:04 omaiborodahj

@emartynov @ntustzeus @wlTrunks @AlexMoumou @omaiborodahj @danmajercak the decoupling was already implemented and merged into the main branch. In the next release 2.28.0, planned to be done by late May, a second lib OpenTok_Transformers will be opt-in. The OpenTok lib size returned to its normal size

goncalocostamendes avatar Apr 30 '24 16:04 goncalocostamendes