OpenTok-PHP-SDK icon indicating copy to clipboard operation
OpenTok-PHP-SDK copied to clipboard

Update Firebase PHP-JWT to ^6.1

Open steveneaston opened this issue 2 years ago • 1 comments

Description

Updates Firebase PHP-JWT to the latest version (6.1.0) and adds the now required $alg argument for JWT::encode. Also updates the TestHelper to use Firebase\JWT\Key for JWT::decode.

Breaking changes outlined in the 6.0.0 release notes: https://github.com/firebase/php-jwt/releases/tag/v6.0.0.

Motivation and Context

6.0.0 fixes a security flaw https://github.com/firebase/php-jwt/issues/351 https://security.snyk.io/vuln/SNYK-PHP-FIREBASEPHPJWT-2434829

^6.0 is also now required by https://github.com/laravel/passport from ≥10.4.0.

How Has This Been Tested?

Existing tests make use of JWT::encode and JWT::decode and pass.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

steveneaston avatar Apr 12 '22 17:04 steveneaston

Codecov Report

Merging #297 (61da830) into main (1493c01) will not change coverage. The diff coverage is 100.0%.

Impacted Files Coverage Δ
src/OpenTok/Util/Client.php 75.9% <100.0%> (ø)

codecov[bot] avatar May 10 '22 08:05 codecov[bot]

Merged in #318

steveneaston avatar Jan 03 '23 15:01 steveneaston