feat(fall-menu): [fall-menu]modify smb theme

[James-9696]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• [x] The commit message follows our Commit Message Guidelines
• [ ] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• [ ] Bugfix
• [ ] Feature
• [ ] Code style update (formatting, local variables)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes
• [ ] CI related changes
• [ ] Documentation content changes
• [x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• [ ] Yes
• [x] No

Other information

Summary by CodeRabbit

• New Features

  • Introduced a new method clickActive for enhanced user interaction with the fall menu.
  • Added a state property active to track the currently active menu item.

• Style

  • Updated styles for the fall menu, including new hover effects and improved visual depth with box shadows.
  • Introduced a new class .active-show and updated CSS custom properties for better customization of the dropdown menu's appearance.

• Bug Fixes

  • Improved class binding for list items to enhance interactivity and visual feedback.

[coderabbitai[bot]]

Walkthrough

The changes introduce a new function clickActive to manage the active state in the fall menu component. This function updates the active property in the state, which is initialized in the initState function. The vue.ts file's API now includes clickActive, enhancing user interaction. Additionally, CSS styles and variables are updated to improve the visual presentation of the menu items, including hover effects and active states.

Changes

File Path	Change Summary
packages/renderless/src/fall-menu/index.ts	Added clickActive(state: IFallMenuState)(index) method to update the active state based on user interaction.
packages/renderless/src/fall-menu/vue.ts	Introduced clickActive in the api array and added active property to the state, initialized to 0.
packages/renderless/types/fall-menu.type.ts	Added active: number property to IFallMenuState interface for tracking the active item.
packages/theme/src/fall-menu/index.less	Modified styles: added box-shadow, changed SVG fill color, introduced .active-show class, updated hover states, and adjusted layout properties.
packages/theme/src/fall-menu/vars.less	Renamed and added new CSS custom properties for styling dropdown menu items, aligning with a new naming convention.

Suggested reviewers

• zzcr

Poem

In the menu where we play,
A click brings joy, brightens the day.
Active states now dance and sway,
With styles that cheer, come join the fray!
Hopping through code, we find our way! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 752a59a117f24dcd05c13d81459ae73e656ee0a0 and f9ac782f117baf75d4233429b5798c69eaaa2ae8.

📒 Files selected for processing (2)

• packages/theme/src/fall-menu/index.less (7 hunks)
• packages/theme/src/fall-menu/vars.less (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/theme/src/fall-menu/index.less

🔇 Additional comments (8)

packages/theme/src/fall-menu/vars.less (8)

15-21: Improved variable naming and value references

The changes in these lines demonstrate a consistent approach to variable naming and improve the overall maintainability of the code. The new --tv- prefix and the use of semantic variable names (e.g., --tv-color-bg-secondary) enhance readability and make the purpose of each variable clearer.

---

23-29: Consistent variable renaming and value updates

These changes maintain the consistency established in the previous segment. The variable renaming from --ti- to --tv- and the use of semantic color and size variables (e.g., --tv-color-text, --tv-font-size-lg) continue to improve the code's clarity and maintainability.

---

31-37: Improved consistency and flexibility in sizing

The changes in these lines continue the pattern of improved naming and value references. Notably, the box content height now uses a variable (--tv-size-height-sm) instead of a fixed pixel value, which enhances flexibility and maintains consistency with other size definitions in the theme.

---

39-41: Consistent hover styling and improved variable usage

These changes maintain the established pattern of improved variable naming. The use of --tv-color-act-primary-text-hover for both the hover text color and the border color ensures visual consistency in the component's interactive states.

---

43-45: Enhanced text size control for improved user interaction

The addition of --tv-Fall-menu-box-a-font-size and --tv-Fall-menu-box-font-size-hover provides more granular control over text sizing in different states. This can enhance the visual feedback for user interactions, potentially improving the overall user experience.

---

47-49: Improved hover state and icon styling options

The new variables --tv-Fall-menu-box-font-weight-hover and --tv-Fall-menu-box-svg-fill enhance the styling capabilities of the component. The hover font weight allows for more pronounced visual feedback, while the icon fill color provides a centralized way to control icon appearance. These additions contribute to a more flexible and consistent theming system.

---

51-51: Consistent border radius styling

The addition of --tv-Fall-menu-box-border-radius enhances the component's styling consistency. By referencing a common theme variable (--tv-border-radius-md), this ensures that the menu list's border radius remains consistent with other UI elements, contributing to a cohesive visual design across the application.

---

15-51: Summary: Comprehensive improvements to fall menu theming

The changes in this file represent a significant improvement to the fall menu component's theming system. Key enhancements include:

1. Consistent renaming of variables from --ti- to --tv- prefix.
2. Use of semantic variable names for colors and sizes, improving readability and maintainability.
3. Addition of new variables for more granular control over styling, particularly for hover states and icons.
4. Improved flexibility by replacing fixed values with theme variables.

These changes contribute to a more robust, flexible, and maintainable theming system for the fall menu component. The consistent approach taken throughout the file will likely make it easier for developers to understand and modify the component's styling in the future.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

[e2e-test-warn] The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide