tiny-vue icon indicating copy to clipboard operation
tiny-vue copied to clipboard

fix: fix type: "module" must need js file extensions

Open gweesin opened this issue 1 year ago • 2 comments

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

missing js file extensions on import statement

Issue Number: #569

What is the new behavior?

generated renderless file import statement could contains js file extensions

cd packages/renderless

run pnpm build

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Better than #1880

Summary by CodeRabbit

  • New Features

    • Introduced a streamlined build configuration that enhances the build process.
    • Transitioned to a new build tool for improved performance and compatibility.
    • Added new scripts for more granular control over code building and type definition generation.
  • Bug Fixes

    • Clean-up process implemented to ensure that previous build artifacts do not interfere with new builds.

gweesin avatar Aug 15 '24 14:08 gweesin

Walkthrough

The recent updates to the renderless package involve establishing a new build configuration with the unbuild package, enhancing the build process. The transition from tsup to unbuild indicates a shift in the development workflow, aimed at improving build performance and maintaining a clean output. This streamlined approach simplifies project setup and ensures efficient management of build artifacts.

Changes

Files Change Summary
packages/renderless/build.config.ts Introduced a new build configuration file using unbuild, defining a clean build process with a single entry point that points to the ./src/ directory.
packages/renderless/package.json Updated the build script to execute pnpm build:code and pnpm build:dts, replacing the previous single command, and added unbuild as a new dependency.
packages/renderless/tsup.config.ts Removed the configuration for compiling TypeScript files from the src directory, focusing instead on generating types from types/*.type.ts.

Suggested labels

bug

Poem

In the meadow, changes bloom,
A build tool swap, we clear the gloom.
From tsup to unbuild, we leap with glee,
Crafting builds as smooth as can be!
Hops of joy with every line,
Clean outputs, oh how they shine! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 15 '24 14:08 coderabbitai[bot]

[e2e-test-warn] The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

github-actions[bot] avatar Aug 15 '24 14:08 github-actions[bot]