tiny-vue icon indicating copy to clipboard operation
tiny-vue copied to clipboard

chore: bump vitest related deps

Open gweesin opened this issue 1 year ago • 6 comments

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

image

Issue Number: N/A

What is the new behavior?

Performance improvement

caba0dcd2a46c22ad8d479ae997a2a7a

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

gweesin avatar Aug 02 '24 16:08 gweesin

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

190 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

coderabbitai[bot] avatar Aug 02 '24 16:08 coderabbitai[bot]

[e2e-test-warn] The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

github-actions[bot] avatar Aug 02 '24 16:08 github-actions[bot]

@gweesin 建议只修改以下3个命令涉及到的 vitest 版本号:

    "test:unit2": "pnpm -C examples/vue2 test:unit",
    "test:unit2.7": "pnpm -C examples/vue2.7 test:unit",
    "test:unit3": "pnpm -C examples/vue3 test:unit",

其他无关的无需修改

kagol avatar Aug 04 '24 11:08 kagol

Bot detected the issue body's language is not English, translate it automatically.


@gweesin recommends modifying only the vitest version numbers involved in the following three commands:

    "test:unit2": "pnpm -C examples/vue2 test:unit",
    "test:unit2.7": "pnpm -C examples/vue2.7 test:unit",
    "test:unit3": "pnpm -C examples/vue3 test:unit",

No other irrelevant changes need to be made

Issues-translate-bot avatar Aug 04 '24 11:08 Issues-translate-bot

@gweesin 建议只修改以下3个命令涉及到的 vitest 版本号:

    "test:unit2": "pnpm -C examples/vue2 test:unit",
    "test:unit2.7": "pnpm -C examples/vue2.7 test:unit",
    "test:unit3": "pnpm -C examples/vue3 test:unit",

其他无关的无需修改

修改这些点主要基于以下两个原则:

  1. vitest 关联的运行时内核 jsdom、关联的 vite(vitest 2.x 需要 vite 5.x)统一升级
  2. 统一monorepo下依赖包版本

gweesin avatar Aug 07 '24 03:08 gweesin

Bot detected the issue body's language is not English, translate it automatically.


@gweesin recommends modifying only the vitest version numbers involved in the following three commands:

"test:unit2": "pnpm -C examples/vue2 test:unit",
"test:unit2.7": "pnpm -C examples/vue2.7 test:unit",
"test:unit3": "pnpm -C examples/vue3 test:unit",

Other irrelevant items do not need to be modified.

Modifying these points is mainly based on the following two principles:

  1. The runtime kernel jsdom and associated vitest associated with vitest (vitest 2.x requires vite 5.x) are upgraded uniformly
  2. Unify dependency package versions under monorepo

Issues-translate-bot avatar Aug 07 '24 03:08 Issues-translate-bot

代码有冲突,可以解决下,我先合入再验证下

zzcr avatar Sep 02 '24 03:09 zzcr

Bot detected the issue body's language is not English, translate it automatically.


There is a conflict in the code. It can be resolved. I will merge it first and then verify it.

Issues-translate-bot avatar Sep 02 '24 03:09 Issues-translate-bot