tiny-vue icon indicating copy to clipboard operation
tiny-vue copied to clipboard

Published 20 hours ago • verified publisher icon opentiny

test: [divider, split, tag] fix current test errors

Open gweesin opened this issue 1 year ago • 7 comments

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our Commit Message Guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

b75d906b87a6d682fb8f7b29c30f185d

Issue Number: N/A

What is the new behavior?

image

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Summary by CodeRabbit

  • Tests
    • Updated test assertions for better alignment with the new styling conventions in various components.
    • Enhanced specificity of color definitions in tests for improved rendering consistency.
    • Modified event handler naming convention in tests to reflect the updated standards.
    • Improved type safety and corrected element indices in event handling tests for better accuracy.
    • Adjusted mouse movement distances and height expectations in tests for more precise UI behavior validation.

gweesin avatar Aug 02 '24 16:08 gweesin

Walkthrough

The recent changes involve updates to test cases for various Vue components, focusing on enhancing accuracy and aligning with updated naming conventions. Key modifications include adjustments to class names, color formats, event handler names, and bounding box assertions, as well as refinements in mouse movement parameters and height expectations. These changes collectively aim to improve the reliability and clarity of the tests.

Changes

Files Change Summary
.../config-provider/__tests__/config-provider.spec.ts
.../divider/__test__/divider.test.tsx
.../split/__tests__/split.test.tsx
.../sites/demos/pc/app/split/moveend-event.spec.ts
.../sites/demos/pc/app/split/movestart-event.spec.ts
.../sites/demos/pc/app/split/split-threshold.spec.ts		 Tests updated for improved accuracy:
- Class name changed for RTL in config-provider.
- Color format updated to RGB in divider.
- Event handler casing corrected in split.
- Non-null assertions added for bounding boxes in movement events.
- Mouse movement distances and height expectations modified in split-threshold.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SplitComponent
    User->>SplitComponent: Interacts with element
    SplitComponent-->>User: Triggers mousedown event

🐰 In the meadow of code where the rabbits play,
Changes hop in with a leap and a sway.
Class names and colors dance in delight,
Testing becomes clearer, everything feels right!
With each little update, our components gleam,
Building a future, oh, what a dream! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 02 '24 16:08 coderabbitai[bot]

@gweesin 以下命令可以单独执行某个组件的单元测试用例，这样验证起来会快一些

pnpm test:unit3 button

kagol avatar Aug 04 '24 11:08 kagol

Bot detected the issue body's language is not English, translate it automatically.

@gweesin The following command can execute the unit test case of a certain component separately, so that the verification will be faster

pnpm test:unit3 button

Issues-translate-bot avatar Aug 04 '24 11:08 Issues-translate-bot

@gweesin 以下命令可以单独执行某个组件的单元测试用例，这样验证起来会快一些

pnpm test:unit3 button

ok了解了！我之前单独跑的时候直接改vite.config.ts配置文件的单元测试扫描路径来做调试，多此一举了🤣

gweesin avatar Aug 04 '24 13:08 gweesin

Bot detected the issue body's language is not English, translate it automatically.

@gweesin The following command can execute the unit test case of a certain component separately, so that the verification will be faster

pnpm test:unit3 button

ok got it! When I ran it alone before, I directly changed the unit test scan path of the vite.config.ts configuration file for debugging, which was unnecessary. 🤣

Issues-translate-bot avatar Aug 04 '24 13:08 Issues-translate-bot

@gweesin split/tag组件的e2e测试用例报错

kagol avatar Aug 05 '24 07:08 kagol

Bot detected the issue body's language is not English, translate it automatically.

@gweesin The e2e test case of the split/tag component reports an error

Issues-translate-bot avatar Aug 05 '24 07:08 Issues-translate-bot

你好，代码有冲突，修改下，我来合入哈

zzcr avatar Aug 26 '24 03:08 zzcr

Bot detected the issue body's language is not English, translate it automatically.

Hello, there is a conflict in the code. Please modify it and I will merge it.

Issues-translate-bot avatar Aug 26 '24 03:08 Issues-translate-bot

这么mr貌似有点问题740个文件改动，是不是分支污染了，可以重新拉个分支提交

zzcr avatar Aug 27 '24 08:08 zzcr

Bot detected the issue body's language is not English, translate it automatically.

It seems that there is something wrong with MR. 740 files have been changed. Is the branch contaminated? You can re-pull a branch and submit it.

Issues-translate-bot avatar Aug 27 '24 08:08 Issues-translate-bot

这么mr貌似有点问题740个文件改动，是不是分支污染了，可以重新拉个分支提交

确实奇怪，我based分支压根没这些调整，但却要我处理这些conflict，我看看重新拉个分支

gweesin avatar Aug 28 '24 04:08 gweesin

Bot detected the issue body's language is not English, translate it automatically.

There seems to be something wrong with MR. 740 files have been changed. Is the branch contaminated? You can re-pull a branch and submit it.

It's really strange. My based branch doesn't have these adjustments at all, but it requires me to deal with these conflicts. I'll try and pull a new branch.

Issues-translate-bot avatar Aug 28 '24 04:08 Issues-translate-bot

已合入新拉的分支，这个mr我就关闭了哈

zzcr avatar Aug 29 '24 01:08 zzcr

Bot detected the issue body's language is not English, translate it automatically.

It has been merged into the new branch. I will close this mr.

Issues-translate-bot avatar Aug 29 '24 01:08 Issues-translate-bot