tiny-engine icon indicating copy to clipboard operation
tiny-engine copied to clipboard

optimize:Cj subsequent optimization

Open STATICHIT opened this issue 1 year ago • 1 comments

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

Background and solution

后续优化

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

Other information

Summary by CodeRabbit

  • New Features

    • Enhanced plugin navigation panel with drag-and-drop functionality for top and bottom navigation items.
    • Introduced a toggle feature for an AI robot component to improve user interaction with AI features.
  • Improvements

    • Updated confirmation logic for switching plugins to enhance user experience.
    • Refined context menu logic for more dynamic interactions.
  • Refactor

    • Improved overall structure and state management of the navigation lists for better organization and maintainability.

STATICHIT avatar Sep 30 '24 15:09 STATICHIT

Walkthrough

The changes across multiple components focus on enhancing the layout and functionality of the plugin navigation panel. Key updates include the addition of dynamic class bindings to indicate the drag state, new methods for managing the visibility of an AI component, and improved state management for drag-and-drop interactions. The overall structure of the components has been refined to support these enhancements, leading to a more organized and interactive user interface.

Changes

File Change Summary
packages/design-core/src/DesignPlugins.vue - Added dynamic class binding for drag state.
- Introduced openAIRobot method for AI component visibility.
- Added getMoveDragBarState method for drag state management.
packages/common/component/PluginPanel.vue - Updated event handling for resizing, incorporating changeMoveDragBarState.
- Maintained existing resizing logic with improved state management.
packages/controller/src/useLayout.js - Added isMoveDragBar reactive property to track drag state.
- Introduced getMoveDragBarState and changeMoveDragBarState methods for state management.
packages/design-core/src/DesignCanvas.vue - Added dynamic class binding for the canvas based on drag state.
- Updated nodeSelected method for improved visibility handling.
packages/design-core/src/DesignSettings.vue - Introduced dynamic class binding for the settings panel based on drag state.
- Updated to include getMoveDragBarState in reactive data flow.

Possibly related PRs

  • #600: This PR modifies the DesignPlugins.vue component by adding the openAIRobot method, which is related to managing the visibility of an AI robot component, similar to the changes in the main PR that also introduced the openAIRobot method.
  • #794: This PR enhances the DesignPlugins.vue component by introducing drag-and-drop functionality for rearranging plugins, which aligns with the overall improvements in user interaction and state management in the main PR.
  • #804: This PR introduces a context menu in DesignPlugins.vue, enhancing user interaction, which is a focus of the main PR's changes to improve the plugin navigation panel's functionality.

Suggested labels

enhancement, refactor-main

Suggested reviewers

  • hexqi
  • lizhijie429

Poem

In the realm of design, where plugins unite,
We've added some magic to make things feel right.
With drag bars that dance and menus that gleam,
Our AI robot's ready, fulfilling the dream!
So hop through the changes, let creativity flow,
Together we’ll flourish, let our ideas grow! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9af9a4028db0002b1ac57ee396c2ffde3b370672 and 63b42ab9d57960cf4bbb6302f5f4500f1d40fea0.

📒 Files selected for processing (1)
  • packages/design-core/src/DesignSettings.vue (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/design-core/src/DesignSettings.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 30 '24 15:09 coderabbitai[bot]

image 插件隐藏功能没有生效

hexqi avatar Oct 29 '24 09:10 hexqi

Bot detected the issue body's language is not English, translate it automatically.


image Plug-in hiding function does not take effect

Issues-translate-bot avatar Oct 29 '24 09:10 Issues-translate-bot