tiny-engine icon indicating copy to clipboard operation
tiny-engine copied to clipboard

Feat(page): 新增页面管理导出components,扩展AstroPro页面模板功能

Open betterdancing opened this issue 1 year ago • 1 comments

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced PluginSetting for managing plugin settings.
    • Added new components: PageMain and PageGeneral for enhanced page structure.
    • Launched PageMain.vue for streamlined page and folder management with new creation functionalities.
  • Improvements

    • Refactored components for better modularity and dynamic rendering.
    • Enhanced flexibility in component management through registry-based references.
  • Bug Fixes

    • Removed obsolete imports and components to simplify functionality.

betterdancing avatar Sep 13 '24 03:09 betterdancing

Walkthrough

The pull request introduces several modifications across multiple files, primarily focusing on enhancing the exports of various modules. Key changes include the addition of PageGeneral and pageSettingApi to the index.js file in the page plugin, along with the restructuring of component rendering in PageSetting.vue. A new reactive reference, selectedTemplateCard, is added in usePage.js, expanding the module's capabilities. Overall, these updates enhance functionality while maintaining existing logic.

Changes

Files Change Summary
packages/plugins/page/index.js Added PageGeneral and pageSettingApi to the exported object; updated apis property to include both APIs.
packages/plugins/page/src/PageSetting.vue Replaced <page-general> with <component :is="pageGeneral">; introduced beforeCreatePage method in api object; modified createPage to be asynchronous.
packages/plugins/page/src/composable/usePage.js Added new reactive reference selectedTemplateCard and updated export statement to include it.

Possibly related PRs

  • #556: The changes in this PR involve reexporting various plugins and settings in the design-core package, which includes modifications to the packages/design-core/index.js file, similar to the changes made in the main PR regarding exports.
  • #578: This PR includes changes to the DesignPlugins.vue file that involve renaming properties and enhancing the structure of the component, which may relate to the overall organization of exports and components in the main PR.
  • #794: This PR introduces drag-and-drop functionality for plugins and enhances layout management, which could be relevant to the changes in the main PR that involve exporting new components and settings.
  • #804: The modifications in this PR enhance the visibility and management of menus within the layout, which aligns with the changes in the main PR regarding the organization of exports and components.
  • #826: This PR focuses on modifying the UI of the advanced panel, which may relate to the overall design and export structure changes in the main PR.
  • #827: This PR addresses bugs related to the block panel functionality, which could be connected to the changes in the main PR that involve the organization and export of components related to the block panel.

Suggested labels

enhancement, ospp-2024

Suggested reviewers

  • hexqi
  • lizhijie429

🐰 "In the garden of code, we hop with delight,
New components sprout, making everything bright.
With exports enhanced, and structure refined,
Our plugin's a treasure, oh so well-designed!
So let’s dance through the changes, with joy in our hearts,
For in this code burrow, creativity starts!" 🎉


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d8484609760eb2b7e2115ea121d98da711d8b789 and 31e6ea0a135848a2effb882cfab30c2921959ddf.

📒 Files selected for processing (1)
  • packages/plugins/page/index.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/plugins/page/index.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 13 '24 03:09 coderabbitai[bot]