tiny-engine icon indicating copy to clipboard operation
tiny-engine copied to clipboard

fix(theme-base): update theme-base package and add common file

Open James-9696 opened this issue 1 year ago • 1 comments

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [x] Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced a comprehensive set of custom CSS variables for theming, including background colors, text colors, borders, and button styles, enhancing design consistency across the application.
    • Implemented a more modular approach to theme styling with dynamic loading of theme-specific styles based on the environment variable.
  • Style

    • Updated various components' color variables to utilize new common color variables, improving visual consistency and alignment with the updated design theme across the application.
  • Refactor

    • Improved organization of CSS variable declarations to facilitate easier theming and maintainability throughout the application.
    • Removed previously defined exported theme objects to streamline theme management.
    • Introduced new files for light and dark theme configurations, allowing for future customization of TinyVue components.

James-9696 avatar Jul 11 '24 03:07 James-9696

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent updates to the application enhance its theming capabilities by introducing an organized collection of CSS custom properties for visual elements such as background colors, borders, and text hues. This modular approach allows for simplified customization and promotes consistency across UI components. Additionally, various theme management files have been updated or introduced, improving the overall structure and maintainability of the styling system.

Changes

Files/Groups Change Summary
packages/theme/base/src/common.less Introduced a comprehensive set of CSS custom properties for visual elements (e.g., backgrounds, text colors, borders) organized by type, enhancing theming consistency and usability.
packages/theme/light/block.less, packages/theme/light/events.less, packages/theme/light/help.less Updated various color variables in block, event, and help components to utilize new common color variables, improving visual consistency across these UI elements.
packages/theme/base/src/index.js, packages/design-core/src/init.js Removed previous theme exports (tinyEngineThemeLight and tinyEngineThemeDark) and modified TinyThemeTool initialization, shifting to a new theme management approach with imports of tinyThemeLightVars and tinyThemeDarkVars.
packages/theme/base/src/dark/dark-common.js, packages/theme/base/src/light/light-common.js Introduced new files for dark and light theme configurations (dark-common.js and light-common.js), each exporting an empty object for future theme properties, supporting modular theme management.
packages/theme/base/src/base.less New file defining a comprehensive set of CSS custom properties for a consistent design system across the application.
packages/plugins/block/src/Main.vue, packages/plugins/data/src/DataSourceList.vue, packages/plugins/i18n/src/Main.vue, packages/plugins/materials/src/meta/block/src/BlockGroup.vue, packages/plugins/page/src/PageInputOutput.vue, packages/plugins/page/src/PageSetting.vue, packages/plugins/tree/src/Main.vue, packages/settings/events/src/components/AdvanceConfig.vue, packages/settings/panel/src/Main.vue Multiple adjustments to CSS properties within various components to enhance styling consistency and visual feedback, including changes to hover states, margin removals, and variable updates.
packages/theme/light/index.less, packages/theme/light/pageManage.less, packages/theme/light/datasource.less, packages/theme/light/variable.less, packages/theme/light/tree.less Various updates to CSS custom properties, including renaming and reorganization to align with a unified naming convention, improving maintainability across the styling framework.

Possibly related PRs

  • #624: This PR introduces a new package for tiny-engine-theme-base, which is directly related to the theming changes in the main PR.

Suggested labels

enhancement

Poem

In the land of code, where styles unite,
New custom properties bring joy and delight.
Colors aligned, with themes to explore,
A rabbit's vision of a design we adore.
With every change, the UI does gleam,
In harmony we code, like a well-crafted dream.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- I pushed a fix in commit <commit_id>, please review it. -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples: -- @coderabbitai generate unit testing code for this file. -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -- @coderabbitai read src/utils.ts and generate unit testing code. -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 11 '24 03:07 coderabbitai[bot]