feat: merge preview entry with index entry
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] The commit message follows our Commit Message Guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] Built its own designer, fully self-validated
PR Type
What kind of change does this PR introduce?
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
- [ ] Yes
- [ ] No
Other information
Summary by CodeRabbit
-
New Features
- Updated favicon and webpage title for a refreshed look.
-
Bug Fixes
- Simplified URL construction in preview mode for consistent behavior.
-
Refactor
- Cleaned HTML inclusion configuration, focusing only on
index.html. - Updated component imports in
Toolbar.vuefor more efficient usage.
- Cleaned HTML inclusion configuration, focusing only on
Walkthrough
The recent update encompasses modifications to various packages, notably centered around simplifying the preview logic, altering HTML inclusions in the build config, and refining component imports within the Toolbar.vue. These changes enhance code maintainability by streamlining configurations, updating imports, and adjusting the logic to remove unnecessary preview functionality across different files.
Changes
| File | Change Summary |
|---|---|
| designer-demo/index.html | Updated favicon link and webpage title |
| packages/.../src/default-config.js | Removed preview.html from the input and updated includeHtmls array to include only index.html |
| packages/controller/js/preview.js | Commented out isDevelopEnv import and simplified openUrl construction to always use ${href}/preview?tenant=${tenant}#${hashString} |
| packages/design-core/index.js | Removed export of initPreview |
| packages/design-core/src/init.js | Added import for initPreview and adjusted export functions to conditionally call based on URL path |
| packages/.../preview/src/Toolbar.vue | Restructured component imports to use entry properties instead of component |
Sequence Diagrams
sequenceDiagram
participant User
participant App
participant PreviewComponent
User->>App: Request URL
alt URL is "/preview"
App->>PreviewComponent: Call initPreview
PreviewComponent-->>App: Initialized Preview
else URL is not "/preview"
App->>PreviewComponent: Call initMain
PreviewComponent-->>App: Initialized Main
end
Poem
🐰✨
In code we weave the magic bright,
Removing clutter, setting things right.
With previews streamlined, simpler with glee,
Enhanced our tools for you and me.
Refined and tidy, swift as a hare,
Celebrate updates with care. 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
这个是有点反方向操作了感觉, preview应该是元应用 ,只是被单独渲染, 不应该和main启动器耦合, 应该往元应用(第一个单独被渲染的元应用)+ 提供一个元应用单独渲染器发展
Bot detected the issue body's language is not English, translate it automatically.
This feels a bit like operating in the opposite direction. The preview should be a meta-application, which is only rendered separately. It should not be coupled with the main launcher. It should go to the meta-application (the first meta-application that is rendered independently) + provide a meta-application for independent rendering. device development