tiny-engine icon indicating copy to clipboard operation
tiny-engine copied to clipboard

feat: external most dependencies of core package

Open chilingling opened this issue 9 months ago • 1 comments

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

Summary by CodeRabbit

  • Chores
    • Expanded the list of external dependencies across multiple build configurations to exclude additional packages from bundling. This update helps optimize bundle size and dependency management for end-users. No changes to user-facing features or functionality.

chilingling avatar Mar 20 '25 09:03 chilingling

Walkthrough

The Vite build configurations across multiple packages were updated to expand the list of external dependencies in their Rollup options. These changes introduce additional explicit package names and regex patterns, ensuring a broader set of modules are treated as external and excluded from the bundled output, affecting how dependencies are resolved during the build process.

Changes

File(s) Change Summary
packages/canvas/vite.config.ts
packages/settings/styles/vite.config.ts
Added new external dependencies, including explicit package names like '@vueuse/core', 'postcss', and regex patterns for @babel and @vue packages, broadening the set of modules excluded from the bundle.
packages/common/vite.config.ts Expanded external dependencies with new regex patterns for @vueuse, @vue, and added specific packages 'axios' and 'vue-draggable-next' as externals.
packages/design-core/vite.config.js Broadened external dependencies by adding explicit package names and regex patterns for @vue/*, @babel/*, @vueuse/*, and generalizing @opentiny/tiny-engine-* packages.
packages/layout/vite.config.ts
packages/settings/props/vite.config.ts
packages/toolbars/lang/vite.config.ts
packages/toolbars/view-setting/vite.config.ts
packages/plugins/schema/vite.config.ts
Added '@vueuse/core' and/or 'vue-draggable-next' as external dependencies to the Rollup config, expanding the modules excluded from the bundle.
packages/plugins/block/vite.config.ts Added '@vue/shared' as an external dependency in the Rollup config.
packages/plugins/datasource/vite.config.js Added '@vue/shared', 'axios', and 'vue-clipboard3' as external dependencies.
packages/plugins/i18n/vite.config.ts Added 'vue-clipboard3' as an external dependency.
packages/vue-generator/vite.config.js Added 'vue', 'vue-eslint-parser', and regex patterns for @vue/ and @opentiny/tiny-engine packages to the external dependencies list.

Sequence Diagram(s)

sequenceDiagram
    participant ViteConfig
    participant Rollup
    participant ExternalModule
    participant Bundle

    ViteConfig->>Rollup: Provide external dependencies list
    Rollup->>ExternalModule: Check if module matches external pattern
    alt Module is external
        ExternalModule-->>Bundle: Exclude from bundle
    else Module is not external
        ExternalModule-->>Bundle: Include in bundle
    end

Poem

In the meadow of configs, a rabbit hops with glee,
Expanding externals, as far as the eye can see.
Regex and names, all lined up in a row,
Bundles grow slimmer, dependencies kept low.
With each new pattern, the build hops anew—
A carrot for you, and a bundle that’s true! 🥕

[!NOTE]

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.


[!NOTE]

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings. Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 616f266b2ffbd1c6978c7c0c3b070885c7447e3c and 27a1d646b115fabe7ef53f700fcb9f087f484ffc.

📒 Files selected for processing (1)
  • packages/common/vite.config.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/common/vite.config.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 20 '25 09:03 coderabbitai[bot]