tiny-engine icon indicating copy to clipboard operation
tiny-engine copied to clipboard

fix: buildinCompStyle compact nested scenario

Open chilingling opened this issue 10 months ago • 1 comments

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our Commit Message Guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

Background and solution

修复内置 Canvas行列容器组件在嵌套场景下,样式会发生透传的 bug

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

Summary by CodeRabbit

  • New Features

    • Enabled enhanced layout customization with dynamic styling options across components.
    • Introduced a configurable option for adjusting row spacing in container elements.
  • Refactor

    • Streamlined styling by shifting from static to inline dynamic style bindings, improving responsiveness and flexibility.

chilingling avatar Feb 05 '25 03:02 chilingling

Walkthrough

The changes update several Vue components to apply dynamic styling directly within the template rather than relying on static CSS in the <style> section. Each component now computes style properties from its props and binds them inline. One component additionally introduces a new prop (rowGap) to allow reactive updates of the row-gap style. No modifications have been made to the exported or public entities.

Changes

File(s) Change Summary
packages/builtinComponent/src/components/CanvasCol.vue, packages/builtinComponent/src/components/CanvasFlexBox.vue, packages/builtinComponent/src/components/CanvasRow.vue Updated templates to bind dynamic styles using computed properties derived from props; removed corresponding static CSS style bindings from the <style> sections.
packages/builtinComponent/src/components/CanvasRowColContainer.vue Introduced dynamic binding for the row-gap style via Vue binding and added a new rowGap prop (type [String, Number], default ''), replacing the previous static assignment.

Sequence Diagram(s)

sequenceDiagram
    participant Parent
    participant Component
    participant Template
    Parent->>Component: Pass style-related props
    Component->>Component: Compute dynamic style object
    Component->>Template: Bind computed styles inline (via :style or :styles)
    Template->>Browser: Render element with updated styles

Possibly related PRs

  • opentiny/tiny-engine#938: Addresses dynamic styling enhancements similar to these changes, particularly in the CanvasCol.vue and CanvasFlexBox.vue components.

Suggested labels

bug, refactor-main

Suggested reviewers

  • hexqi
  • gene9831

Poem

In the meadow of code I hop with delight,
Dynamic styles gleam in the soft Vue light.
Flex, gap, and align now dance in tune,
A transformation beneath a binary moon.
CodeRabbit cheers—hop on, keep shining bright! 🐇

[!TIP]

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Feb 05 '25 03:02 coderabbitai[bot]