canary
canary copied to clipboard
Small issues after cancelling while in "You are dead" window
Priority
Low
Area
- [ ] Datapack
- [X] Source
- [ ] Map
- [ ] Other
What happened?
- Mysql error when we click "cancel" in death window, and login again on same character:
[2022-02-08 03:44:32.659] [info] Asdf has logged in
[2022-02-08 03:44:32.659] [error] Query: INSERT INTO `players_online` VALUES (9)
[2022-02-08 03:44:32.659] [error] Message: Duplicate entry '9' for key 'PRIMARY'
Simple solution is to move IOLoginData::updateOnlineStatus(guid, false);
outside isLogout
check in: https://github.com/opentibiabr/canary/blob/1f07781fdf762ce8aa0a379d28380ca3dd60cf70/src/creatures/players/player.cpp#L1637-L1650
- While cancelling in death window VIP status is not being updated from
VIPSTATUS_PENDING
toVIPSTATUS_OFFLINE
. It should be added in some disconnect function, but I couldnt find where exactly.
What OS are you seeing the problem on?
Windows
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
1- Was tested and worked.
I don't understand how to fix it