canary icon indicating copy to clipboard operation
canary copied to clipboard

Fixed imbued item not start the imbuement timer countdown

Open dudantas opened this issue 2 years ago • 9 comments

Resolves #467

dudantas avatar Aug 01 '22 20:08 dudantas

Tested and seems fine now

Thanks for send feedback!

dudantas avatar Aug 01 '22 22:08 dudantas

@CleberMoreira Does the timer start if you imbue unequpped item and then equip it? Or maybe you had no "infight" mode (sword icon)

gerotib avatar Aug 01 '22 22:08 gerotib

@CleberMoreira Does the timer start if you imbue unequpped item and then equip it? Or maybe you had no "infight" mode (sword icon)

I tested it and when I imbue the item with it equipped it really isn't decaying, it only resolved when I imbue it with it unequipped

dudantas avatar Aug 01 '22 22:08 dudantas

Apparently some items decay, others don't. I'm trying to find the pattern. It seems that only the first imbued item after login decays, on imbuing another item it no longer decays.

dudantas avatar Aug 03 '22 03:08 dudantas

@gerotib I sent one more commit that should solve the problem, can you test again?

dudantas avatar Aug 03 '22 03:08 dudantas

@dudantas it doesn't start the timer now. With only first commit it sometimes did and sometimes didnt, I tried to find a way to reproduce, but I really dont get it

gerotib avatar Aug 04 '22 00:08 gerotib

@dudantas it doesn't start the timer now. With only first commit it sometimes did and sometimes didnt, I tried to find a way to reproduce, but I really dont get it

I'll have to investigate a bit more about this, I'm also having trouble understanding.

dudantas avatar Aug 04 '22 11:08 dudantas

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Sep 15 '22 04:09 github-actions[bot]

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Dec 03 '22 02:12 github-actions[bot]

Hello, I'm not sure if this PR is still open and being investigated, but I'm using the latest Canary version and I noticed that the imbuement countdown stops counting only after the 60min automatic server save, I've tested many times and it always happens after the ss.

156323233 avatar Jan 02 '23 15:01 156323233

@156323233 @gerotib @CleberMoreira please test again

dudantas avatar Jan 08 '23 08:01 dudantas

@dudantas I have introduced this fix, but, apart from the fact that the imbuiments don't work (they don't give critical, mana, life) even if you don't have the weapon equipped and you have PZ, it lowers your CD.

cojucoti avatar Jan 15 '23 21:01 cojucoti