[Enhancement] Protocol update to 12.91

[marcosvf132]

Description

Update tibia protocol to 12.91, including the following features:

• Timer on rings/amulets.
• Charge number on rings/amulets.
• Npc fix. (Sell/Buy more than 100 items at once)
• Two new depot boxes

Type of change

• [x] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] This change requires a documentation update

Fixes

Resolves #318 Resolves #386

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I checked the PR checks reports
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works

[tutbarao]

Error sell item in npc. "bad argument #4 to 'format' (number expected, got string)"

script: player:sendTextMessage(MESSAGE_INFO_DESCR, string.format("Sold %ix %s for %i gold.", amount, name, totalCost))

[Darkedo]

hello marcos can you see my comment in this rp from a month ago if you do i just recompile i found two issues with npc -any selling to npc gets erorr in console -anything u buy from npc shop like mana or sd only buy with bp you cant buy x charges

[carlospess0a]

I tested the reports from @Darkedo and @tutbarao and I couldn't reproduce these errors.

I tested buying stuff in NPC and everything is working fine.

I'm using both PR to test, 443 and 732 from otbr.

[Darkedo]

I tested the reports from @Darkedo and @tutbarao and I couldn't reproduce these errors.

I tested buying stuff in NPC and everything is working fine.

I'm using both PR to test, 443 and 732 from otbr.

[carlospess0a]

I tested the reports from @Darkedo and @tutbarao and I couldn't reproduce these errors. I tested buying stuff in NPC and everything is working fine. I'm using both PR to test, 443 and 732 from otbr.

You need this PR 732 due rework of npc system.

[Darkedo]

I tested the reports from @Darkedo and @tutbarao and I couldn't reproduce these errors. I tested buying stuff in NPC and everything is working fine. I'm using both PR to test, 443 and 732 from otbr.

You need this PR 732 due rework of npc system.

thanks carlos worked

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

0.0% Coverage
0.0% Duplication

[tutbarao]

Não é possivel comprar items sem a bag shopping. Eu clico em remover bag shopping e ele vme sempre com ela.

[guispiller]

Por favor, não comente em PRs fechados. Esse PR ja foi fechado a mais de um mês, e isso que você reportou está funcionando normal atualmente, você provavelmente não sincronizou os npcs do otbr com a nova mudança. Pr favor, atualize sua source e datapack.