canary
canary copied to clipboard
opentibiabr
[Feature] Item tiers and new skills (Onslaught, Ruse and Momentum) from 12.80
Note: This pull request is not yet complete, it is in the testing and development phase, thank you.
The forge system part will be completed in another pull request, and focused after I finish these!
New Item Tiers and classifications
Added functions
item:getTier()
item:addTier(tier)
need a tiered item? use the commited script, you can copy to OTservBR-Global datapack if you want
New skills
All informations avaliable in Tibia Fandom Onslaught(Fatal): https://tibia.fandom.com/wiki/Onslaught Ruse(block hits): https://tibia.fandom.com/wiki/Ruse Momentum(cooldown reduction): https://tibia.fandom.com/wiki/Momentum
Missing
- [x] Missing some item tier bytes.
- [x] Market saving tier attribute. and more, much more things.
Type of change
- [X] New feature (non-breaking change which adds functionality)
Global tibia examples:
You see a lion rod (magic level +2, critical hit chance 10%, critical extra damage +35%). Imbuements: (Powerful Void 1:24h, Powerful Epiphany 1:24h). Classification: 4 Tier: 1 (0.50% Onslaught).
Classification: 2 Tier: 1 (2.00% Momentum).
Classification: 3 Tier: 1 (0.50% Ruse).
forged items can't be used as a hotkey
The packet got longer and includes u8 tier now. Also you have to assign upgraded item again because the hotkey on action bar is set to equip "tier 0 armor"
forged items can't be used as a hotkey
The packet got longer and includes u8 tier now. Also you have to assign upgraded item again because the hotkey on action bar is set to equip "tier 0 armor"
where should i change this to fix it?
@tutbarao here is how I did it for hotkey equip: https://github.com/Zbizu/forgottenserver/commit/2a18fc8ba813c2f38f87367fbc0e8350783a4f44#diff-eb01d79b279ebf659ed73216c0b3c490685221c9358e058ce55a1c8ab4e99c35R1145
I don't remember if there was anything I changed for hotkey use though.
Thanks, is there any scripts that add dust loot drop chance on all monsters?
when I click and select "sliver" or "exalted core" client crashes with "2022-07-16, 23:15:02: Error while processing network packet not enough bytes (28777) available at position 25". Did I miss something or maybe you have the same issue?
Now the tier no longer appears when looking at the item it shows tier = [] and the hotkey is only functional for tier 1 item. above tier 1 it doesn't work
Now the tier no longer appears when looking at the item it shows tier = [] and the hotkey is only functional for tier 1 item. above tier 1 it doesn't work
stop using the comment section as custom support, the pull request is in draft, that's = to not completed yet please wait for everything to be done then you can test, I'll mark your comments as outdated
when I click and select "sliver" or "exalted core" client crashes with "2022-07-16, 23:15:02: Error while processing network packet not enough bytes (28777) available at position 25". Did I miss something or maybe you have the same issue?
working as should there!
When unequipping with hotkey the item with an infinite bag "loot pouch" with +1 page. Item disappears when unequipped. This bug happens with any item, even non-forged items.
Would be great if we have the getClassification() method in lua, what do you think? item_functions.cpp
int ItemFunctions::luaItemGetClassification(lua_State* L) { const Item* item = getUserdata<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); return 1; }
lua_pushnumber(L, item->getClassification()); return 1; }
item_functions.hpp
registerMethod(L, "Item", "getClassification", ItemFunctions::luaItemGetClassification);`
and
`static int luaItemGetClassification(lua_State* L);
Hello, I just downloaded the current src with version 12.86. I added all the changes posted here. I tried several times to be sure that I did not make a mistake when adding them and it causes me an error when I try to log in 1 character, the server closes and only shows 1 message in the console (segmentation fault) the problem in windown and now in ubuntu 20.04
outra coisa é que alguns items como "spellbook of dark mysteries" por algum motivo não para ser add ao market
Did you check your client with Asset Editor?
Não sei se aqui é o lugar certo, dois erros nesse pr é, só da para criar offerts no market de itens que podem receber tier, e o outro só da para equipar quiver pela hotkey se não tiver nada na mão, por favor o pr é muito bom para ter esses dois bugs
os items não perdem mais tier quando são vendidos no market mais ainda não é possível criar oferta de items que tem NÃO POSSUEM classificação tier
os items não perdem mais tier quando são vendidos no market mais ainda não é possível criar oferta de items que tem NÃO POSSUEM classificação tier
que não possuem classificação tier ou que não possuem o upgradeclassfication? eu consegui por um item que tem tier 0 sem problema algum
os items não perdem mais tier quando são vendidos no market mais ainda não é possível criar oferta de items que tem NÃO POSSUEM classificação tier
que não possuem classificação tier ou que não possuem o upgradeclassfication? eu consegui por um item que tem tier 0 sem problema algum
Qualquer item que nao tenha a classificação tier nao pode ser adicionado ao market. Exemplo: steel boots nao pode ser adicionado ao market pois nao possue tier.
Qualquer item que nao tenha a classificação tier nao pode ser adicionado ao market. Exemplo: steel boots nao pode ser adicionado ao market pois nao possue tier.
Acabei de arrumar, fica a vontade para testar. Também botei para aparecer todas as classificações no market, na hora de pôr para vender.
Eu tenho esse erro agora na source ao criar uma oferta no market de uma steel boots ou qualquer outro item sem tier.
`[error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 0 AND `itemtype` = 3554 AND `tier` =
[2022-06-10 17:48:33.312] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1
[2022-06-10 17:48:33.313] [error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 0 AND `itemtype` = 3554 AND `tier` =
[2022-06-10 17:48:33.314] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1
[2022-06-10 17:48:33.315] [error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 1 AND `itemtype` = 3554 AND `tier` =
[2022-06-10 17:48:33.315] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1
[2022-06-10 17:48:33.316] [error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 1 AND `itemtype` = 3554 AND `tier` =
[2022-06-10 17:48:33.316] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1`
@tutbarao você precisa rodar o migrations https://github.com/opentibiabr/otservbr-global/pull/799
#Edit Realmente ta dando bug, já já vejo oq é
Eu tenho esse erro agora na source ao criar uma oferta no market de uma steel boots ou qualquer outro item sem tier.
`[error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 0 AND `itemtype` = 3554 AND `tier` = [2022-06-10 17:48:33.312] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1 [2022-06-10 17:48:33.313] [error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 0 AND `itemtype` = 3554 AND `tier` = [2022-06-10 17:48:33.314] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1 [2022-06-10 17:48:33.315] [error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 1 AND `itemtype` = 3554 AND `tier` = [2022-06-10 17:48:33.315] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1 [2022-06-10 17:48:33.316] [error] Query: SELECT `id`, `amount`, `price`, `tier`, `created`, `anonymous`, (SELECT `name` FROM `players` WHERE `id` = `player_id`) AS `player_name` FROM `market_offers` WHERE `sale` = 1 AND `itemtype` = 3554 AND `tier` = [2022-06-10 17:48:33.316] [error] Message: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1`
Fixado, vê o último commit, por gentileza.
Mais algum bug? Precisamos que testem bem, amanhã começarei a desenvolver a statistics e aí estará pronto para mergear. Só dependerá dos testes.
Everything working perfect, i would just suggest that tiered items should not be able to be sold on npcs
Found a new issue on market related to tiers. How to reproduce, with an example of Plate armor (you can use any item).
1 - create a buy offer of a plate armor tier 0 with Player A. 2 - Get 1 Plate armor Tier 1 on first slot of a depot box, and one plate armor Tier 0 at the second slot of the same depot box. 3 - Sell the plate armor tier 0 to the buy offer at the market.
Result: As the first slot is the Tier 1 armor, this one will be sold. So, player A will receive a Tier 0 armor, and player B will sell a Tier 1 armor. This can occur also if there are tiered items of the same at mailbox, and lower tiered on depot box. It is not checking the tier, it's just selling the first one
Found a new issue on market related to tiers. How to reproduce, with an example of Plate armor (you can use any item).
1 - create a buy offer of a plate armor tier 0 with Player A. 2 - Get 1 Plate armor Tier 1 on first slot of a depot box, and one plate armor Tier 0 at the second slot of the same depot box. 3 - Sell the plate armor tier 0 to the buy offer at the market.
Result: As the first slot is the Tier 1 armor, this one will be sold. So, player A will receive a Tier 0 armor, and player B will sell a Tier 1 armor. This can occur also if there are tiered items of the same at mailbox, and lower tiered on depot box. It is not checking the tier, it's just selling the first one
Thanks for reporting. Please, test this commit: https://github.com/opentibiabr/canary/pull/366/commits/d0d3482da484f1beb9d3966a65210fc4faebf26a
I tested it, and it seems to have fixed the problem.
I found a bug: Cannot cancel market offers. When you click the cancel button, nothing happens.