ot-ns icon indicating copy to clipboard operation
ot-ns copied to clipboard

[cli] fix - graceful handling of accidental user input of node 0

Open EskoDijk opened this issue 2 years ago • 3 comments

EskoDijk avatar Aug 30 '22 07:08 EskoDijk

Codecov Report

Merging #350 (b3418c3) into main (c616148) will decrease coverage by 0.04%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   49.97%   49.93%   -0.05%     
==========================================
  Files          38       38              
  Lines        4608     4604       -4     
==========================================
- Hits         2303     2299       -4     
  Misses       2123     2123              
  Partials      182      182              
Impacted Files Coverage Δ
cli/CmdRunner.go 23.13% <0.00%> (ø)
dispatcher/dispatcher.go 57.10% <0.00%> (ø)
web/site/bindata.go 99.00% <ø> (-0.01%) :arrow_down:
otnstester/OtnsTest.go 89.44% <100.00%> (ø)

codecov-commenter avatar Aug 30 '22 07:08 codecov-commenter

@EskoDijk Please rebase the PR to resolve checks. So for other multiple PRs.

simonlingoogle avatar Sep 03 '22 07:09 simonlingoogle

@EskoDijk Please rebase the PR to resolve checks. So for other multiple PRs.

@simonlingoogle The rebase is done now, the remaining failing "Develop" runs are failing in all PRs for some reason.

EskoDijk avatar Sep 20 '22 08:09 EskoDijk