ot-br-posix icon indicating copy to clipboard operation
ot-br-posix copied to clipboard

Conditionalize Avahi Service Start and Installation (#2280)

Open kevinanderson1 opened this issue 1 year ago • 4 comments

Ensure the Avahi daemon is installed and started only when OTBR_MDNS == "avahi". This prevents multiple mDNS stacks from running especially in container environments.

I saw in the CONTRIBUTING documentation that CI checks should pass but I'm not sure how to get them to run in my fork.

kevinanderson1 avatar May 10 '24 20:05 kevinanderson1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.77%. Comparing base (2b41187) to head (1fb1360). Report is 660 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2282       +/-   ##
===========================================
- Coverage   55.77%   39.77%   -16.01%     
===========================================
  Files          87       88        +1     
  Lines        6890     9778     +2888     
  Branches        0      721      +721     
===========================================
+ Hits         3843     3889       +46     
- Misses       3047     5691     +2644     
- Partials        0      198      +198     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 21:05 codecov[bot]

I saw in the CONTRIBUTING documentation that CI checks should pass but I'm not sure how to get them to run in my fork.

The CI tests run in this PR. You will need to pass those failing tests.

Screenshot from 2024-05-11 07-58-07

wgtdkp avatar May 10 '24 23:05 wgtdkp

@superwhd I believe this is ready for review.

kevinanderson1 avatar May 16 '24 18:05 kevinanderson1

LGTM overall except concern of failing to include avahi in BR reference release.

superwhd avatar May 17 '24 07:05 superwhd

@superwhd I've modified the PR to ensure Avahi is installed if REFERENCE_DEVICE=1. Let me know if anything else needs to be addressed.

kevinanderson1 avatar May 20 '24 19:05 kevinanderson1