openthread icon indicating copy to clipboard operation
openthread copied to clipboard

[github-actions] limit "upload coverage" job to openthread repo

Open abtink opened this issue 1 year ago • 4 comments

This commit updates the GitHub Action workflows to skip the "upload-coverage" job when target repo is a fork of openthread.

abtink avatar Apr 30 '24 20:04 abtink

Size Report of OpenThread

Merging #10136 into main(0c6c2fedadf6516282f4430da89d2b99d551934a).

name branch text data bss total
ot-cli-ftd main 466840 856 66364 534060
#10136 466840 856 66364 534060
+/- 0 0 0 0
ot-ncp-ftd main 435756 760 61576 498092
#10136 435756 760 61576 498092
+/- 0 0 0 0
libopenthread-ftd.a main 235928 95 40310 276333
#10136 235928 95 40310 276333
+/- 0 0 0 0
libopenthread-cli-ftd.a main 57545 0 8075 65620
#10136 57545 0 8075 65620
+/- 0 0 0 0
libopenthread-ncp-ftd.a main 31863 0 5916 37779
#10136 31863 0 5916 37779
+/- 0 0 0 0
ot-cli-mtd main 364504 760 51220 416484
#10136 364504 760 51220 416484
+/- 0 0 0 0
ot-ncp-mtd main 347036 760 46448 394244
#10136 347036 760 46448 394244
+/- 0 0 0 0
libopenthread-mtd.a main 157999 0 25182 183181
#10136 157999 0 25182 183181
+/- 0 0 0 0
libopenthread-cli-mtd.a main 39787 0 8059 47846
#10136 39787 0 8059 47846
+/- 0 0 0 0
libopenthread-ncp-mtd.a main 24743 0 5916 30659
#10136 24743 0 5916 30659
+/- 0 0 0 0
ot-cli-ftd-br main 549976 864 131212 682052
#10136 549976 864 131212 682052
+/- 0 0 0 0
libopenthread-ftd-br.a main 324242 100 105134 429476
#10136 324242 100 105134 429476
+/- 0 0 0 0
libopenthread-cli-ftd-br.a main 71208 0 8099 79307
#10136 71208 0 8099 79307
+/- 0 0 0 0
ot-rcp main 62248 564 20604 83416
#10136 62248 564 20604 83416
+/- 0 0 0 0
libopenthread-rcp.a main 9542 0 5052 14594
#10136 9542 0 5052 14594
+/- 0 0 0 0
libopenthread-radio.a main 18870 0 214 19084
#10136 18870 0 214 19084
+/- 0 0 0 0

size-report[bot] avatar Apr 30 '24 20:04 size-report[bot]

It seems the code coverage report has been missing for a while. Is this PR fixing the issue?

bukepo avatar May 11 '24 01:05 bukepo

It seems the code coverage report has been missing for a while. Is this PR fixing the issue?

No, not directly. Though it might help indirectly. It prevents the "update coverage" step from running on forks of the OT repo, limiting it to the main repo. This should reduce traffic to the underlying Coverity server, which could potentially improve its performance and responsiveness.

abtink avatar May 13 '24 18:05 abtink

It seems the code coverage report has been missing for a while. Is this PR fixing the issue?

It appears Codecov has errors processing coverage reports. For example: https://app.codecov.io/gh/openthread/openthread/commit/acacdbff85e766403a1886c8b02b3c25a823a680

jwhui avatar May 14 '24 02:05 jwhui