gentropy icon indicating copy to clipboard operation
gentropy copied to clipboard

feat(l2g): merge sQTL and tuQTL colocalisation features

Open ireneisdoomed opened this issue 4 months ago • 0 comments

✨ Context

This PR closes https://github.com/opentargets/issues/issues/3553#issue-2556031237

🛠 What does this PR implement

  • Removal of the tuQTL specific features
  • When colocalisation features, tuQTL colocalisation values are taking into account as a type of sQTL

🙈 Missing

I haven't run it.

🚦 Before submitting

  • [x] Do these changes cover one single feature (one change at a time)?
  • [x] Did you read the contributor guideline?
  • [x] Did you make sure to update the documentation with your changes?
  • [x] Did you make sure there is no commented out code in this PR?
  • [x] Did you follow conventional commits standards in PR title and commit messages?
  • [x] Did you make sure the branch is up-to-date with the dev branch?
  • [ ] Did you write any new necessary tests?
  • [x] Did you make sure the changes pass local tests (make test)?
  • [x] Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

ireneisdoomed avatar Oct 09 '24 13:10 ireneisdoomed