ext-openswoole icon indicating copy to clipboard operation
ext-openswoole copied to clipboard

Regarding php_swoole_library.h

Open ClosetGeek-Git opened this issue 2 years ago • 2 comments

Does Openswoole plan to indefinitely maintain it's PHP usersland library within ext-src/php_swoole_library.h? I believe it would be a better practice to reseparate the PHP code from the hard-coded library.

ClosetGeek-Git avatar May 31 '22 06:05 ClosetGeek-Git

@ClosetMonkey thanks for the feedback, we are thinking about this. We can see the good side that it is more easy to manage the release of the library; while the downside is people have to install both the extension and PHP library when it is splitted.

One approach would be moving some essential functions back into C++ then split, as the splitting will cause BC breaks.

doubaokun avatar Jun 01 '22 15:06 doubaokun

I guess my first question would be is there any precedent either way and how other common libraries handle it?

jedjones-uk avatar Jun 01 '22 15:06 jedjones-uk

@ClosetMonkey @jedjones-uk it will be removed from v22 coming soon. Thanks for the suggestion.

doubaokun avatar Sep 20 '22 08:09 doubaokun