core
core copied to clipboard
refactor(terminal): use launchConfig
Types
- [x] 🎉 New Features
Background or solution
Breaking Change:
- 修正 TerminalServiceClientImpl.create2 返回的 INodePtyInstance 对象中的 typo: packages/terminal-next/src/node/terminal.service.client.ts
export interface INodePtyInstance {
id: string;
name: string;
pid: number;
- proess: string;
+ process: string;
shellPath?: string;
}
- 移除 createTerminalClientFactory
请使用 createTerminalClientFactory2 createTerminalClientFactory 在 core 主体代码中已经没有使用到了
- createClientWithWidget2 重命名为 createTerminalWithWidgetByTerminalOptions
- 移除 createClientWithWidget
Changelog
- 支持 Rerun Last Task
- 优化了启动 Terminal 相关的逻辑
Codecov Report
Merging #1528 (f035129) into main (a22d51d) will increase coverage by
41.90%. The diff coverage is44.17%.
@@ Coverage Diff @@
## main #1528 +/- ##
===========================================
+ Coverage 15.76% 57.67% +41.90%
===========================================
Files 1250 1253 +3
Lines 78030 78155 +125
Branches 16297 16327 +30
===========================================
+ Hits 12303 45073 +32770
+ Misses 60119 30117 -30002
+ Partials 5608 2965 -2643
| Flag | Coverage Δ | |
|---|---|---|
| jsdom | 52.47% <31.84%> (?) |
|
| node | 15.84% <12.32%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/i18n/src/common/en-US.lang.ts | 100.00% <ø> (ø) |
|
| packages/i18n/src/common/zh-CN.lang.ts | 100.00% <ø> (ø) |
|
| packages/task/src/common/index.ts | 100.00% <ø> (+100.00%) |
:arrow_up: |
| ...-next/src/browser/contribution/terminal.command.ts | 0.00% <ø> (ø) |
|
| ...xt/src/browser/contribution/terminal.keybinding.ts | 0.00% <0.00%> (ø) |
|
| ...nal-next/src/browser/contribution/terminal.view.ts | 0.00% <ø> (ø) |
|
| packages/terminal-next/src/browser/index.ts | 0.00% <0.00%> (ø) |
|
| ...ckages/terminal-next/src/browser/terminal.addon.ts | 36.11% <ø> (+36.11%) |
:arrow_up: |
| packages/terminal-next/src/browser/terminal.api.ts | 0.00% <0.00%> (ø) |
|
| ...inal-next/src/browser/terminal.internal.service.ts | 55.93% <ø> (+55.93%) |
:arrow_up: |
| ... and 811 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
ref #1531.
ref #1531.
1531 还没修