core
core copied to clipboard
refactor: replace nsfw with @parcel/watcher
Types
- [x] 🪚 Refactors
Background or solution
close #915
详细背景见讨论区 #302.
Changelog
replace nsfw with @parcel/watcher
https://github.com/opensumi/core/pull/1437/commits/0caba8889f67dba68fc0a85db38038c68c3289c2 这个 commit 将所有测试内针对 Logger 的 Mock 逻辑统一移动到了全局 Injector 初始化阶段,简化大量代码
把 logger 相关的 mock 逻辑全都统一规范到 createBrowserInjector 和 createNodeInjector 里面了,后续单元测试编写起来代码会更加简练一些。
Codecov Report
Merging #1437 (76abb58) into main (052a035) will decrease coverage by
0.11%
. The diff coverage is80.58%
.
@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 57.86% 57.74% -0.12%
==========================================
Files 1251 1250 -1
Lines 78023 78022 -1
Branches 16281 16296 +15
==========================================
- Hits 45145 45057 -88
- Misses 29938 30015 +77
- Partials 2940 2950 +10
Flag | Coverage Δ | |
---|---|---|
jsdom | 52.53% <69.90%> (+0.03%) |
:arrow_up: |
node | 15.76% <56.31%> (-0.15%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
packages/core-browser/src/opener/command-opener.ts | 21.05% <ø> (ø) |
|
packages/core-common/src/types/file-watch.ts | 67.74% <ø> (ø) |
|
...s/core-node/src/common-module/credential.server.ts | 12.50% <ø> (ø) |
|
packages/debug/src/common/debug-model.ts | 17.39% <0.00%> (ø) |
|
...xtension/src/hosted/api/vscode/ext.host.command.ts | 67.60% <ø> (ø) |
|
packages/extension/src/hosted/extension-log2.ts | 0.00% <ø> (ø) |
|
packages/file-service/src/common/files.ts | 86.84% <ø> (ø) |
|
...s/main-layout/src/common/main-layout.definition.ts | 100.00% <ø> (ø) |
|
...c/browser/abstract-resource-preference-provider.ts | 82.55% <ø> (ø) |
|
...es/terminal-next/src/browser/links/link-manager.ts | 23.95% <ø> (ø) |
|
... and 26 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/publish
🎉 PR Next version 2.19.7-next-1660547126.0 publish successful! You can install prerelease version via npm install [email protected]
@Ricbet
2.19.7-next-1660547126.0
/publish
🎉 PR Next version 2.19.9-next-1660814799.0 publish successful! You can install prerelease version via npm install [email protected]
@erha19
2.19.9-next-1660814799.0
/publish
🎉 PR Next version 2.19.9-next-1660830232.0 publish successful! You can install prerelease version via npm install [email protected]
@erha19
2.19.9-next-1660830232.0
修改相应的 Breaking Change 文档如下:采用 @parcel/watcher 作为文件服务新的监听库