core icon indicating copy to clipboard operation
core copied to clipboard

feat: unify compressing

Open songhn233 opened this issue 3 years ago • 2 comments

Types

  • [x] 🪚 Refactors

Background or solution

Close #976

image

https://github.com/node-modules/compressing/pull/73 有一个待合并的类型 typo,在代码中先重新定义了

Changelog

  • 解压缩统一依赖为 Compressing

songhn233 avatar Jul 10 '22 15:07 songhn233

@songhn233 冲突处理一下 ~

erha19 avatar Aug 15 '22 07:08 erha19

@songhn233 冲突处理一下 ~

Done.

songhn233 avatar Aug 16 '22 15:08 songhn233

@songhn233 测试还是受到影响了,可能是这个文件 node/log.service.test.ts,可以用框架项目内的 launch.json 中定义的 Jest Current File 命令调试一下测试

erha19 avatar Aug 22 '22 08:08 erha19

Codecov Report

Merging #1299 (a1e4a9e) into main (a22d51d) will increase coverage by 41.87%. The diff coverage is 14.81%.

@@             Coverage Diff             @@
##             main    #1299       +/-   ##
===========================================
+ Coverage   15.76%   57.63%   +41.87%     
===========================================
  Files        1250     1251        +1     
  Lines       78030    78081       +51     
  Branches    16297    16315       +18     
===========================================
+ Hits        12303    45004    +32701     
+ Misses      60119    30112    -30007     
+ Partials     5608     2965     -2643     
Flag Coverage Δ
jsdom 52.46% <11.11%> (?)
node 15.72% <3.70%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...browser/src/extensions/extensions-point.service.ts 29.54% <0.00%> (-1.41%) :arrow_down:
...core-browser/src/extensions/schema/browserViews.ts 100.00% <ø> (+100.00%) :arrow_up:
...ages/core-browser/src/extensions/schema/toolbar.ts 100.00% <ø> (+100.00%) :arrow_up:
...xtension-manager/src/node/vsx-extension.service.ts 0.00% <0.00%> (ø)
...nsion/src/browser/sumi/contributes/browser-main.ts 100.00% <ø> (+100.00%) :arrow_up:
...xtension/src/browser/sumi/contributes/node-main.ts 83.33% <ø> (+83.33%) :arrow_up:
...sion/src/browser/sumi/contributes/views-proxies.ts 100.00% <ø> (+100.00%) :arrow_up:
...ension/src/browser/sumi/contributes/worker-main.ts 83.33% <ø> (+83.33%) :arrow_up:
...ension/src/browser/vscode/contributes/debuggers.ts 16.88% <ø> (+16.88%) :arrow_up:
packages/i18n/src/common/contributes/en-US.lang.ts 100.00% <ø> (ø)
... and 788 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 23 '22 22:08 codecov[bot]

@songhn233 测试还是受到影响了,可能是这个文件 node/log.service.test.ts,可以用框架项目内的 launch.json 中定义的 Jest Current File 命令调试一下测试

@erha19 嗯看了下应该是一些副作用,一旦这个 case 通过后面的执行就会 crash,实际不影响

不过 GetLogZipArchiveByDay 本来就没有被使用到,这里测试我先 skip 掉吧~

songhn233 avatar Aug 24 '22 01:08 songhn233

@songhn233 这个文件测试还是存在问题 logs-core/__tests__/node/log-manager.test.ts ,相关代码可能比较陈旧,需要修改可以直接就改了

erha19 avatar Aug 24 '22 10:08 erha19

@songhn233 这个文件测试还是存在问题 logs-core/__tests__/node/log-manager.test.ts ,相关代码可能比较陈旧,需要修改可以直接就改了

可以,处理了~

songhn233 avatar Aug 24 '22 16:08 songhn233

@songhn233 https://github.com/node-modules/compressing/pull/73 这里已经发了一个 1.6.1 版本,感觉可以升级一下把多余的 typo 定义去掉

erha19 avatar Aug 25 '22 02:08 erha19

@songhn233 node-modules/compressing#73 这里已经发了一个 1.6.1 版本,感觉可以升级一下把多余的 typo 定义去掉

可以,之前定义已经去掉了。我把版本也明确一下到 ^1.6.2

songhn233 avatar Aug 25 '22 03:08 songhn233