service.subtitles.opensubtitles_by_opensubtitles icon indicating copy to clipboard operation
service.subtitles.opensubtitles_by_opensubtitles copied to clipboard

Opensubtitles addon does not work for Kodi Matrix

Open masca90021 opened this issue 5 years ago • 6 comments

Hi guys,

Is there any updated file for Kodi Matrix ? I am in need of an update. Ty in advance,

masca90021 avatar Feb 20 '20 08:02 masca90021

Same here, really needs one in Matrix

Zero0Q avatar Mar 05 '20 07:03 Zero0Q

See this for a temp workaround a fully ported python 3 version https://github.com/juokelis/service.subtitles.opensubtitles/tree/Matrix

BramAlkema avatar Mar 18 '20 23:03 BramAlkema

Could @juokelis provide a PR with ported version here?

zdzichu avatar Apr 27 '20 06:04 zdzichu

@juokelis There are two unfortunate issues with your port (https://github.com/juokelis/service.subtitles.opensubtitles/tree/Matrix) First of all you did not start from this repo but from the original opensubtitles addon (https://github.com/opensubtitles/service.subtitles.opensubtitles) and secondly your port now only works with matrix. It would have been better to have the best of all in one addon...

peno64 avatar Feb 21 '21 08:02 peno64

At the moment of porting both repos were abandoned. And for good reason - plugin was working properly on versions prior to Matrix. And another repo was the only one included in the official Kodi plugin project. So it was sole decision what to choose :) We could work together and put new code if there's some benefit for users there to the one submitted to Kodi.

juokelis avatar Feb 21 '21 12:02 juokelis

Well to be hounest, I don't use the opensubtitles addon anymore and not sure if I am interested to modify it. I use subloader (also doing opensubtitles but via a service (is being modified for modi 19 now, I already have a working version)) and a4ksubtitles. The latter is doing opensubtitles, podnadpsi, subscene, addic7ed and bsplayer all in one. Works very good and also already adapted for kodi 19. It works for both kodi 18 and 19.

peno64 avatar Feb 21 '21 12:02 peno64