open-subsonic-api
open-subsonic-api copied to clipboard
opensubsonic
Music Folder extension to extend musicFolderID support to more endpoints
Open questions
- What about playlists containing songs from different music folders? Should the getPlaylist (and getPlaylists) endpoints be scoped down by music folder as well, filtering the playlist by songs contained within a given music folder?
- Should the should language around song and album count on getGenres be changed to must? I didn't want to hold servers back from implementing the extension if it's too complicated to index genre song and album counts by music folder. For an online-first client at least, failing to do so is at worst a slightly confusing UX with the counts not matching what's actually browsable when scoping by music folder.
Deploy Preview for opensubsonic ready!
| Name | Link |
|---|---|
| Latest commit | 374109a3895a00dfa5b3dd0af8cad85819e210c2 |
| Latest deploy log | https://app.netlify.com/projects/opensubsonic/deploys/6874448b7986d00008094b0b |
| Deploy Preview | https://deploy-preview-162--opensubsonic.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think getPlaylist/getPlaylists should receive the param as well.
So if I have a playlist with songs from 2 libraries, when passing a musicFolderId to getPlaylist, I should only receive songs from that library. Also would be used to calculate track counts relative to the given musicFolder, both for getPlaylist and getPlaylists
3.
getShares: only show shares for a given library
IMO, it doesn't makes sense for getShares to have the musicFolderId. AFAIK, shares are not saved per library.