open-subsonic-api icon indicating copy to clipboard operation
open-subsonic-api copied to clipboard

separate playCount into totalPlayCount and userPlayCount

Open lachlan-00 opened this issue 8 months ago • 5 comments

discussed here https://github.com/opensubsonic/open-subsonic-api/discussions/96#discussioncomment-13076513

Essentially deprecate playCount for totalPlayCount and userPlayCount. If the servers don't use the same value for playCount might as well work towards removing it with 2 new items

lachlan-00 avatar May 09 '25 05:05 lachlan-00

Deploy Preview for opensubsonic ready!

Name Link
Latest commit ed65b7c5d01acf55a957d4a3f75dcd894a8e9447
Latest deploy log https://app.netlify.com/sites/opensubsonic/deploys/68212721e2712b00086d4266
Deploy Preview https://deploy-preview-144--opensubsonic.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 09 '25 05:05 netlify[bot]

Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits. Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable

epoupon avatar May 09 '25 07:05 epoupon

For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?

paulijar avatar May 11 '25 19:05 paulijar

Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits. Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable

I would say that it's up to the server though to handle privacy but a good point. a count doesn't give you much information but it does give you information.

lachlan-00 avatar May 11 '25 22:05 lachlan-00

For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?

Sure I'll change that now.

lachlan-00 avatar May 11 '25 22:05 lachlan-00