separate playCount into totalPlayCount and userPlayCount
discussed here https://github.com/opensubsonic/open-subsonic-api/discussions/96#discussioncomment-13076513
Essentially deprecate playCount for totalPlayCount and userPlayCount. If the servers don't use the same value for playCount might as well work towards removing it with 2 new items
Deploy Preview for opensubsonic ready!
| Name | Link |
|---|---|
| Latest commit | ed65b7c5d01acf55a957d4a3f75dcd894a8e9447 |
| Latest deploy log | https://app.netlify.com/sites/opensubsonic/deploys/68212721e2712b00086d4266 |
| Deploy Preview | https://deploy-preview-144--opensubsonic.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits. Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable
For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?
Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits. Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable
I would say that it's up to the server though to handle privacy but a good point. a count doesn't give you much information but it does give you information.
For a reader not having prior knowledge of these discussions, it's not at all obvious that fields
totalCountanduserCounthave anything to do with the times the song has been played. So maybe they should betotalPlayCountanduserPlayCount, even though these require a bit more typing?
Sure I'll change that now.