OpenStudioApplication icon indicating copy to clipboard operation
OpenStudioApplication copied to clipboard

Openstudio application crashes after clicking on thermal zone tab

Open Nischal0150 opened this issue 3 years ago • 7 comments

Issue overview

I am using Openstudio 3.40 to model a building with 50 thermal zones. But every time I click on the thermal zone tab on Openstudio, the application stalls for a few seconds and then crashes abruptly.

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): windows 10
  • Version of OpenStudioApplication 1.4

Context

Nischal0150 avatar Jun 27 '22 03:06 Nischal0150

Moved from https://github.com/NREL/OpenStudio/issues/4617

@Nischal0150 Would you be able to post the model here (you can rename it to a .txt extension and upload it to the issue) or send it privately to [email protected]?

macumber avatar Jun 27 '22 04:06 macumber

Moved from NREL/OpenStudio#4617

@Nischal0150 Would you be able to post the model here (you can rename it to a .txt extension and upload it to the issue) or send it privately to [email protected]?

I have sent the model to [email protected]

Nischal0150 avatar Jun 27 '22 04:06 Nischal0150

Thanks @Nischal0150, I can reproduce the crash. I think this has something to do with NUM_ROWS_PER_GRIDLAYOUT in OSGridView.cpp which is currently set at 50.

macumber avatar Jun 28 '22 05:06 macumber

Another odd thing seems to be that the ThermalZones are missing an inletPortList, was this OSM created through some script or other process? Did it use the OS SDK to create the ThermalZone objects? If you used the OpenStudio SketchUp Plug-in, what version of the plug-in and what version of the OS Application is the plug-in pointed at?

macumber avatar Jun 28 '22 05:06 macumber

Possibly related to https://github.com/openstudiocoalition/OpenStudioApplication/issues/414. The "Add New Thermal Zone For Spaces With No Thermal Zone" seems to be calling the right ThermalZone constructor https://github.com/openstudiocoalition/openstudio-sketchup-plugin/blob/develop/plugin/openstudio/user_scripts/Alter%20or%20Add%20Model%20Elements/Add_New_Thermal_Zone_For_Spaces_With_No_Thermal_Zone.rb#L62

macumber avatar Jun 28 '22 05:06 macumber

Yes, the thermal zones were created through openstudio user script using openstudio sketchup plugin V 1.4.0

Nischal0150 avatar Jun 28 '22 06:06 Nischal0150

Hmm, I was not able to reproduce this using SketchUp 2021 on Windows 11, OpenStudio SketchUp Plug-in 1.4.0, OpenStudio Application 1.4.0, and OpenStudio SDK 1.4.0

image

Can you check your OpenStudio SketchUp Plug-in preferences to make sure that you have the plug-in pointed at the right OpenStudio Application version?

image

macumber avatar Jun 29 '22 02:06 macumber

I can't reproduce this (by making a new model in the SketchUp Plug-in and running the "Add New Thermal Zone For Spaces With No Thermal Zone" user script with 1.5.0-rc.1 either. I'm going to close this issue, we can re-open it if we know how the zones were created without the necessary port objects. The code in the OS ThermalZone constructor hasn't changed for 7 years.

macumber avatar Dec 30 '22 01:12 macumber

Windows 10 OS Application 1.2.1 OS 3.6.1

Same thing is happening - click on a group to change thermal zone, it gives me this:

RuntimeError bad allocation BACKTRACE: C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/DialogManager.rb:321:in setIddObjectType' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/DialogManager.rb:321:in selection_changed' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/interfaces/MaterialsInterface.rb:374:in rendering_mode=' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/dialogs/SpaceAttributesInterface.rb:238:in block in module:OpenStudio' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:262:in block in process_events' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:255:in each' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:255:in process_events' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:318:in block in start_event_processing'

And when I click on Thermal Zones in the Inspector it crashes. It gives me the same error when I click on Render by Thermal Zone. I've tried different versions and I'm still getting it?

lutareeem avatar Aug 28 '23 09:08 lutareeem

@lutareeem are you using the same model as before? Do your ThermalZone objects have valid Zone Air Inlet Port List and Zone Air Exhaust Port List fields?

Here is a ThermalZone from the last example model I got from you in a text editor: image

Here is a ThermalZone from a correct model for reference: image

macumber avatar Sep 02 '23 17:09 macumber

Re-closing until we get more information

macumber avatar Sep 09 '23 18:09 macumber