OpenStudioApplication icon indicating copy to clipboard operation
OpenStudioApplication copied to clipboard

Delete the coil unit in the air loop

Open LouYingli opened this issue 4 years ago • 2 comments

Issue overview

When delete the coil unit in the air loop, the same coil unit in the plant loop cannot be deleted automatically.

Current Behavior

Delete the heating coil in the air loop.

Expected Behavior

The same heating coil in the plant loop should also be deleted automatically.

Steps to Reproduce

  1. Delete the heating coil in the air loop in the HVAC system section.
  2. Run the simulation.
  3. Click show simulation. Following is the video link of this bug. https://drive.google.com/file/d/1G9W8UsjpSdRXxyZd2EbJ_2NJaWZV5qea/view?usp=sharing

Possible Solution

Delete the heating coil in the plant loop manually.

Details

Environment

  • Platform (Operating system, version): Windows 10 Pro (1909) for Workstations
  • Version of OpenStudioApplication: OpenStudio Application 1.1.0

LouYingli avatar Mar 09 '21 22:03 LouYingli

Thnaks for the report @LouYingli

I'm going to have to disagree with the wording on this one. Best case it should perhaps ask if you want to also delete it on the PlantLoop if you remove it from the AirLoopHVAC, or remove it from the AirLoopHVAC if you remove it from the PlantLoop. What do you think about this @LouYingli ?

Automatically wiping it from your model makes for a poor UX. There are many very valid justifications for keeping it: if I realize I put the Coil:Heating:Water on the wrong AirLoopHVAC or PlantLoop, I need to a way to be able to place it somewhere else. if we suddenly start deleting it, you have no way of doing this. If we delete it from both loops, but keep it in the model, chances are it'll be forgotten and orphaned (which is likely to cause issues later in E+), and you'd have to re-add it to two loops instead of just one.

jmarrec avatar Mar 16 '21 13:03 jmarrec

Thank you for the clarification. Yes, I mean I want it to be removed from the AirLoopHVAC if I remove it from the PlantLoop. And I want it to be removed from the PlantLoop if I remove it from the AirLoopHVAC.

LouYingli avatar Mar 16 '21 20:03 LouYingli