operations icon indicating copy to clipboard operation
operations copied to clipboard

OSMF wiki skin is not functional with mediawiki 1.43

Open tomhughes opened this issue 2 months ago • 12 comments

After upgrading the OSMF wiki to 1.43 the skin is no longer functional.

I have raised https://github.com/osmfoundation/osmf-mediawiki-skin/issues/32 and switched it to use the vector skin for now.

tomhughes avatar Nov 11 '25 09:11 tomhughes

If osmf-mediawiki-skin is proving difficult to migrate forward, maybe we could use the Vector 2022 skin for now and use it as a starting point for a new custom skin? Vector 2022 has a layout closer to osmf-mediawiki-skin. At least it would fit the logo better.

1ec5 avatar Nov 17 '25 16:11 1ec5

If osmf-mediawiki-skin is proving difficult to migrate forward, maybe we could use the Vector 2022 skin for now and use it as a starting point for a new custom skin? Vector 2022 has a layout closer to osmf-mediawiki-skin. At least it would fit the logo better.

The ops team do not maintain it. It was presented to us. By all means feel free to have a go at creating something better.

Firefishy avatar Nov 17 '25 16:11 Firefishy

I've switched it to Vector 2022 for now though it's not clear to me that even uses the logo...

tomhughes avatar Nov 17 '25 19:11 tomhughes

it's not clear to me that even uses the logo...

We need to set $wgLogos.

By all means feel free to have a go at creating something better.

Unless we really need a lot of customization, I think it would be a better use of resources to maintain a simple site stylesheet in MediaWiki:Vector-2022.css. We’ll need to do that anyways to fix the layout on the Corporate Members page.

Incidentally, I’m getting an error loading site JavaScript even with this skin:

[032d881e8a5e44ce9fbb3600] 2025-11-17 20:22:22: Fatal exception of type "Error"

1ec5 avatar Nov 17 '25 20:11 1ec5

I've set $wgLogos but only the 1x version as that's all we have and it doesn't seem to make any difference on my (hidpi) laptop.

The javascript issue was down to still having the broken skin loaded so I've disabled it completely now.

tomhughes avatar Nov 17 '25 20:11 tomhughes

Just realised I didn't mention that I managed to get the logo working in the end...

tomhughes avatar Nov 22 '25 11:11 tomhughes

Specific issue I'm seeing right now: the mobile view hides the body text in some pages. Eg: https://osmfoundation.org/w/index.php?title=Licence/Attribution_Guidelines On my iPhone SE 2nd gen, on portrait mode, I can only see the title of the article, but not the body text. No issue in landscape mode.

Portrait Landscape
Image Image

pablobm avatar Nov 22 '25 12:11 pablobm

The default skin on mobile devices is Minerva rather than Vector 2022. You can test this skin by adding the useskin=minerva parameter to the URL. Its desktop and mobile modes have somewhat different behavior. You can force mobile mode by adding useformat=mobile.

In mobile mode, under a certain screen width, Minerva collapses all sections by default and relies on JavaScript to expand it. As I mentioned in https://github.com/openstreetmap/operations/issues/1312#issuecomment-3543698660, the site script isn’t loading due to a server error. Unloading the custom skin didn’t resolve that problem, unfortunately.

1ec5 avatar Nov 22 '25 17:11 1ec5

I fixed the script loading I thought?

tomhughes avatar Nov 22 '25 17:11 tomhughes

After clearing my cache, I’m able to load this script, but Firefox blocks it because of a text/html MIME type and an X-Content-Type-Options: nosniff header.

1ec5 avatar Nov 22 '25 17:11 1ec5

There was a fragment of the foundation skin hanging around that caused chef to restore the load... I've removed it now so the script is loading now.

tomhughes avatar Nov 22 '25 17:11 tomhughes

Yep, it’s working well now. It’s kind of unfortunate that some pages like this start out completely collapsed due to page titles as top-level headings. A simple workaround is to replace = OpenStreetMap Attribution Guideline = with <h1>OpenStreetMap Attribution Guideline</h1>.

1ec5 avatar Nov 22 '25 18:11 1ec5