operations icon indicating copy to clipboard operation
operations copied to clipboard

Wordpress WPML database migrations vulnerable to update race-condition

Open Firefishy opened this issue 2 years ago • 1 comments

The WPML plugin is used on wordpress sites is vulnerable to a race-condition where chef is updating the codebase and a simultaneous web request triggers a partial but incomplete database migration.

WPML marks the migration as complete, but it may not have processed all/any portions of the migration due to the migration codebase files still being deployed.

We should change the deployment code to update the website code + plugins codebase using an atomic action.

Firefishy avatar Nov 29 '23 06:11 Firefishy

This could be mitigated by moving the wordpress services to containers per https://github.com/openstreetmap/operations/issues/807

Firefishy avatar Nov 29 '23 06:11 Firefishy