openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

Display a link for mapillary keys

Open pyrog opened this issue 9 years ago • 23 comments

Hi,

Could you add a link to mapillary=* key of objects (as you do for wikimedia keys) ?

Thanks

pyrog avatar Jun 07 '15 10:06 pyrog

This is kind of exactly why I wasn't keen on doing wikipedia, because it is opening the door to us having to maintain special code to handle hundreds of different sites...

Why exactly would anything be tagged with a mapillary key? Surely people are adding links to individual photos in mapillary to OSM are they?

tomhughes avatar Jun 07 '15 11:06 tomhughes

There are currently 111 such tags in the entire OSM database so I really don't think this meets any kind of threshold where it is significant enough to warrant special code to link to it.

tomhughes avatar Jun 07 '15 11:06 tomhughes

2 years later we have 7.4k instances: https://taginfo.openstreetmap.org/search?q=mapillary The fact that Mapillary is the most substantial source for geo-referenced ground imagery might justify linking to it.

geowOSM avatar May 24 '17 16:05 geowOSM

3 years later, it's now 21.2k instances. It's thrice what we got last year. I will try to have a look.

Gustry avatar Jul 25 '18 23:07 Gustry

I regularly use the mapillary key just as I would use source=*. I link to an image in Mapillary to make it easy to validate my edits to a particular object. Right-clicking on a mapillary tag in JOSM offers the option to open it in an external browser. I find this very useful and sometimes it could be usefull on the website too.

Hjart avatar Jun 25 '19 11:06 Hjart

4 years later, it's now 79 486 instances.

pyrog avatar Jun 26 '19 11:06 pyrog

Not doing that has some bad extra side effects, visible here:

  • full url usage where ID is the correct value i.e mapillary=https://www.mapillary.com/map/im/4mayqgUw7QEHXjeTAXT5nw instead of mapillary=4mayqgUw7QEHXjeTAXT5nw
  • duplicate storage: also referenced as image=https://images.mapillary.com/4mayqgUw7QEHXjeTAXT5nw/thumb-2048.jpg

As said in the ticket 2405 we have a good hint to make it almost maintenance free.

Bibi56 avatar Nov 06 '19 19:11 Bibi56

This (and wikimedia_commons) tags now get turned into hyperlinks in the iD editor since version 2.16.1 https://github.com/openstreetmap/iD/issues/7064 Since iD is just the 'edit' button on the osm website to most people, it would make sense if the actual map also had the same behavior

thibaultmol avatar Dec 04 '19 23:12 thibaultmol

I support adding this. It is important to easily see the source of the object if possible. Until now there are very few special cases like wikimedia_commons, mapillary, flickr and image. You could just decide that if the use is more than x it will be supported. If x=2000 then flickr is the only in that list that would not be supported, see https://wiki.openstreetmap.org/wiki/Key:flickr.

pangoSE avatar Jan 20 '20 13:01 pangoSE

I too would really like to get this. Mapillary is a great resource for contributing to OpenStreetMap so it's pretty ridiculous that this is still not supported. "There are currently 111 such tags in the entire OSM database" : Well time to revisit. The Mapillary field is by far the most common way to link images:

  • mapillary: 128 106 occurrences
  • wikimedia_commons: 22 683 occurrences
  • flickr: 1 245 occurrences

fgouget avatar Feb 15 '20 01:02 fgouget

It's been already over 5 years and this issue is still open. Currenty the mapillary tag has been used 199,003 times. Would it be a problem to add this feature?

Overpass Turbo and iD change it to links. OverpassTurbo

Surely people are adding links to individual photos in mapillary to OSM are they?

Yes, they are.

maro-21 avatar Jan 03 '21 00:01 maro-21

I am not convinced. Randomly checking a few mapillary tags, I found many that ware IMHO unsuitable to serve for verifying anything, eg I see no benches on https://www.openstreetmap.org/node/5764305442, and what does a mapillary tag on a highway=residential prove (eg https://www.openstreetmap.org/way/33654447)? I mean, the object already has a location, and if that exact image the mapillary tag points to doesn't give me more than just "an easy link to Mapillary at this location" then it's really not very useful is it. I don't understand what a sentence like "Mapillary is a great resource for contributing to OpenStreetMap so it's pretty ridiculous that this is still not supported" even means - in how far does contributing to OSM become easier if you can click on Mapillary links? Or "Since iD is just the 'edit' button on the osm website to most people, it would make sense if the actual map also had the same behavior" - iD is the editor. That you use to edit OSM. For which, people say, Mapillary was useful. Why would it have to be a hyperlink on the web site? I'm sorry but this all sounds like let's make the OSM web site an entry point to exploring the map of an area to me, with links to god-knows-what just to make it more fun.

woodpeck avatar Jan 03 '21 02:01 woodpeck

just to make it more fun.

Fun ??

Just to make it more useful

pyrog avatar Jan 03 '21 05:01 pyrog

I mean, the object already has a location, and if that exact image the mapillary tag points to doesn't give me more than just "an easy link to Mapillary at this location" then it's really not very useful is it.

In that case the mapillary ID should be removed from the database. So seeing that it's useless is... useful.

an easy link to Mapillary at this location

Great plugins like OSM Smart Menu or OpenSwitchMaps exist for that use case. No need to pollute the OSM database for that purpose.

Bibi56 avatar Jan 03 '21 10:01 Bibi56

if that exact image the mapillary tag points to doesn't give me more than just "an easy link to Mapillary at this location" then it's really not very useful is it

For me, the appropriate mapillary image allows to check the existence of the OSM object, its position...

Usually it's "easy" to find Mapillary images near an object location, this is more difficult to find a good Mapillary image of this object (could be blurred, far away…).

pyrog avatar Jan 03 '21 11:01 pyrog

I am not convinced. Randomly checking a few mapillary tags, I found many that are IMHO unsuitable to serve for verifying anything

What does that prove? Many are just as useful as Wikimedia links. https://www.openstreetmap.org/node/2699761131 https://www.openstreetmap.org/node/5968451353 https://www.openstreetmap.org/node/5976753716

Or are you suggesting to delete all Wikimedia links too?

I don't understand what a sentence like "Mapillary is a great resource for contributing to OpenStreetMap so it's pretty ridiculous that this is still not supported" even means -

It means most people are uploading images to Mapillary as part of contributing to OpenStreetMap. So when it's appropriate to link to an image to document an object it's a likely that it will already be available in Mapillary. Wikimedia serves a different purpose: its goal is not to have photos of every Wallace fountain but to have one representative photo of a Wallace fountain. What we want in OSM is to provide a photo of the Wallace Fountain in a specific location so applications can show that photo rather than a myriad of other nearby photos that don't show the object and don't allow locating it.

But if you don't think it makes sense to link to Mapillary photos, how do you justify linking to Wikimedia photos? Why the difference in treatment?

fgouget avatar Jan 03 '21 19:01 fgouget

+1 for this feature.

Also, I would like to have kartaview key support added too, fro avoiding Mapillary "monopolizing" image storage. Though we don't have "standardized" kartaview yet, but it starts from somewhere...

I personally started uploading images to Mapillary and KartaView just for sake of anti-vendor-lockin. Having these images easily accessible via main OpenStreetMap site hugely improves motivation to geotag images.

Talkless avatar Aug 02 '21 11:08 Talkless

You realise that's actually an argument for not doing this right? Giving one particular site the advantage of being endorsed by us is bad, but having to add support for hundreds of different sites so that we can say we not giving some people an advantage is also bad.

The solution is not to give anybody special treatment!

tomhughes avatar Aug 02 '21 11:08 tomhughes

I mean, Wikidata external identifier statements link to their respective sites. They're not "giving preference". They're conveniently creating links between fellow open data websites and projects. I don't see why we couldn't do the same, even if it's a lot of sites.

lectrician1 avatar Aug 05 '21 13:08 lectrician1

You realise that's actually an argument for not doing this right? Giving one particular site the advantage of being endorsed by us is bad, but having to add support for hundreds of different sites so that we can say we not giving some people an advantage is also bad.

The solution is not to give anybody special treatment!

This is neither endorsement nor special treatment. I just want my (and other) work (geo-tagged photos) be easily available via main OSM site for all users, not just "geeks" that use overpass-turbo where you do get access to the generated mapillay link...

Talkless avatar Aug 05 '21 19:08 Talkless

Hi, I use pic4review to add details in my local area by creating missions. Other people often contribute to these missions. Quite often other users make mistakes, so I keep an eye on the chagesets

The easiest way to check on other user's contributions at the moment involves clicking on each node of the changeset to open in a different window, then in each window clicking on edit to open iD, finding the node in question and clicking on it, then clicking on the mapillary link to open the photo they used to make this edit.

It's pretty obvious that adding a direct link to mapillary on the OSM website would make this process a lot easier because I wouldn't have to load the editor each and every time.

By making it a lot easier, you would increase the chances that I will bother validating the changes other people make. I don't always because it is so time consuming.

timothywashere avatar Aug 16 '22 11:08 timothywashere

@timothywashere I think your chances of adding such a link to OsmCha are higher and there is a PR doing something similar over there ATM that you could use as reference.

tordans avatar Aug 16 '22 14:08 tordans

Welp.

I came here due to my ongoing project of making a large-scale automated edit converting all the "old" mapillary v3 keys (regexp: [A-Za-z0-9_-]{22}) into their v4 "numeric only" keys.

Let me give you the information that I have gathered in preparation for the edit as a new reference point.

Nowadays, we have around 200k unique "old" keys and 44k unique new keys in the database (on around 280k objects). Of the old keys, only 3,400 no longer have a working numeric id because they have since been deleted. Of these 244k, there are 37k full-flechted http(s)-links in the mapillary key, which will, given how the object-view on the website works, show a link nevertheless.

The wiki states, quite rightly, "This key uses the unique key Mapillary assigns to each photo, not a direct link. The reason for adding the key and not the full URI is that the full URI changed in the past and might change again.".

Should we add a "special treatment" for the mapillary-key on the website, it shall work as such, that a "numeric-only" value of at least 15 consecutive digits links to https://www.mapillary.com/app?focus=photo&pKey={mapillary} - if that part ever changes it will be easy to fix and it will provide more value than those 37k+ links that might become outdated, should the company ever decide to remove legacy support for old links.

Adding to the discussion of the usefulness of a source of streetlevel-imagery that has an OSM-compatible license, I just want to add that, even after the aqcuiration by facebook, the license has not changed, so using that imagery as a source for fact-checking on specific tagging or just viewing points of interest from street level feels like a reasonable thing to be using that imagery for.

I will move forward trying to have the world database contain the most up-to-date API v4 keys (and only one per image) regardless of how this Issue pans out, because it best reflects how the tagging was agreed upon. I, for one, believe that adding an automated link will add value to the website.

Kai

kmpoppe avatar Aug 23 '22 08:08 kmpoppe