openstreetmap
Avoid suggesting to add OSM to home screen in the login flow
Problem
When using OSM as a third party OAuth popup, OSM suggest to add itself to the home screen on Android devices.
Description
It would be great to avoid this suggestion in the OAuth login flow in order to avoid confusing the users of the original app/website. Israel hiking map, in our case.
- I believe it is related to the following feature if I needed to guess: #2361
CC: @1ec5
Screenshots
Why do you think it's a related to a ticket that was closed with no action taken?
One of the "benefits" of PWA is usually this pop up, that allows you to add a website to the home screen. But I might wrong... I can edit this part if it helps, this is not the main point of this issue, obliviously...
Pretty sure we aren’t doing anything specifically to enable installation as an app on Android. We are setting apple-touch-icon and msapplication-TileImage meta tags, but not google-play-app.
Pretty sure we aren’t doing anything specifically to enable installation as an app on Android. We are setting apple-touch-icon and msapplication-TileImage meta tags, but not google-play-app.
PWA does not relate to google-play-app or any other native app.
Yes, and we also don’t provide a PWA manifest or anything like that. @HarelM, could it be something to do with how you’ve implemented the login flow on your end?
Please stop fixating on the word WPA, I made a mistake, please read the issue description. There's nothing special about the login flow on my end, I simply open a window/tab: https://github.com/IsraelHikingMap/Site/blob/0f8efa6441274bd7e093d481d17df9c8ca359163/IsraelHiking.Web/src/application/services/authorization.service.ts#L40
This page says, it's the manifest file:
<link rel="manifest" href="/assets/manifest-e89323590a852a776c60b03fe9cd7bae2ad4dc3fe624dff32bc77899e4c12ba3.json">
Ack you’re right, I missed that when searching the source code of the homepage on my phone last night. 😅 So then this comes from #1558, which we also used for a geo: URI protocol handler in #5736…
According to the statement here: https://github.com/openstreetmap/openstreetmap-website/pull/1558#issuecomment-306233409 It seems that adding to home screen existed before #1558, but I'm guessing @mmd-osm's comment is the relevant one in terms of when this was added...