openstreetmap
Use only differences to OSM logo in internal social link icons
Following the discussion in #6065, this PR drops the OSM logo parts of social link icons for OSM related projects to make the icons more easily distinguishable.
| 1 Warning | |
|---|---|
| :warning: | Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? |
Generated by :no_entry_sign: Danger
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Let's start with a change that shouldn't be in this PR. "Use bs light mode bg secondary color consistently". Are you taking line width into account? (no)
Let's start with a change that shouldn't be in this PR
Removed since taken care of in #6074
The advantage of badges is that the icons take the "same" space, which helps with their alignment. That comes at a cost of adding smaller icons.
If you want to shink the osm logo, you'll have to keep its colors, otherwise it will become unrecognizable. But then you're deviating from https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2577314212 and https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r2090571628.
Why is it the osm logo that's getting shrunk and not the wiki/forum? Why is the osm logo combined with ohm and ogf?
Why is it the osm logo that's getting shrunk and not the wiki/forum?
Because it's not the important part, you see the e.g. the W icon which narrows the platforms down to two options, and the indicator just says if it's osm affiliated or not, osm wiki or standard wikipedia.
If instead the osm icon is the large one, that rather reiterates you're on osm (duh) and more importantly it doesn't resolve the readability issues mentioned in #6065.
Why is the osm logo combined with ohm and ogf?
For ogf it's reasonable to drop in the first place, but the H icon of ohm is quite ambiguous. And when that osm-related platform gets an indicator, that should be the case for every. It doesn't have to be a badge though.
What if we reduce the OHM icon to the outline of the map with the H centered inside of it, similar to the Public Domain Map logo? This would just be an icon anyways, not necessarily the project’s official logo (which obviously needs work). The wiki icon could be something similar with a W, not sure about the others.
Why is it the osm logo that's getting shrunk and not the wiki/forum?
Because it's not the important part, you see the e.g. the W icon which narrows the platforms down to two options, and the indicator just says if it's osm affiliated or not, osm wiki or standard wikipedia.
What are those two options? Osm wiki and Wikipedia? But there's also the ogf wiki.
Doesn't the osm logo also narrow the platforms?
If I add a link to my other osm account, which icon should it get, a large osm logo or a small one over what exactly?
If instead the osm icon is the large one, that rather reiterates you're on osm (duh)
It's on a link, so it doesn't reiterate anything, unless you look up where the link leads. But then you can similarly argue against any icon.
and more importantly it doesn't resolve the readability issues mentioned in #6065.
What does resolve the readability issues? 16x16px "W" as opposed to 12x12px "W" on a badge? (But yes, I'd rather have 16x16 "W" because I'd rather not have badges).
Why is the osm logo combined with ohm and ogf?
For ogf it's reasonable to drop in the first place,
Ogf support is incomplete, only the wiki links are detected but not the main site. By the same logic as currently used in this PR, the ogf logo should become a badge.
but the H icon of ohm is quite ambiguous. And when that osm-related platform gets an indicator, that should be the case for every. It doesn't have to be a badge though.
Are you saying that ohm should have an osm indicator?
But there's also the ogf wiki.
The ogf wiki's logo is considerably different from the icon of other wikis as it resembles more 💭 than a W.
If I add a link to my other osm account, which icon should it get, a large osm logo or a small one over what exactly?
For accounts, reusing avatar.svg is an option. This would be marked as osm-related.
Are you saying that ohm should have an osm indicator?
More or less only because it's icon is an OSM logo derivative, but yes. But decide for yourself in which case the OHM logo is more easily recognisable: