openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

GPX email shouldn't say "Import", it should just say "Upload"

Open jidanni opened this issue 1 year ago • 2 comments

Problem

https://wiki.openstreetmap.org/wiki/Import says

Unlike editing the map or uploading GPX traces, importing combines
an existing dataset with the OSM dataset and thus typically includes a
complex merging process.

Therefore the mail one gets,

Subject: [OpenStreetMap] GPX Import success

shouldn't say "Import", it should just say "Upload".

I messed up https://github.com/openstreetmap/openstreetmap-website/pull/5257 so I'll just open an issue instead.

jidanni avatar Oct 19 '24 07:10 jidanni

I messed up https://github.com/openstreetmap/openstreetmap-website/pull/5257 so I'll just open an issue instead.

You’ve only changed the wrong file, just do your changes in en.yml instead…

mmd-osm avatar Oct 19 '24 07:10 mmd-osm

Actually even though the files say they were exported by ... they should also say "DO NOT EDIT". As far as reading guidelines, yes, but we are often taken to the certain spot via a search, so don't remember to read the guidelines.

Anyway I recall that after cleaning up the GPX Success message, there is also the Failure message, etc. etc. so trust me, you don't want Auntie Nelda (me) loose in your code bin. The damage will be several times worse than what almost already happened. I'll leave it to the pros. Thanks.

jidanni avatar Oct 19 '24 23:10 jidanni

shouldn't say "Import", it should just say "Upload".

Maybe not because import happens after upload, although the emails currently say all of those things:

  • "GPX Import success"
  • "file ... loaded successfully"
  • "successfully uploaded GPX traces"
  • "file ... awaiting insertion in to the database" - this one is in a flash message that also says "file has been uploaded"

So the file is first "uploaded", then (again) "uploaded" or "loaded" or "imported" or "inserted".

AntonKhorev avatar Jan 08 '25 17:01 AntonKhorev