openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

Remove the arm pointing to the new user registration form

Open AntonKhorev opened this issue 10 months ago • 3 comments

There's a arm pointing to the new user form. image

Unfortunately it has a shadow fading into white. This is going to stand out in dark mode. image

The Microsoft redesign https://github.com/openstreetmap/openstreetmap-website/pull/4455 doesn't have the arm. image

Instead of trying to fix the shadow, we might remove the arm even before switching to https://github.com/openstreetmap/openstreetmap-website/pull/4455.

image

AntonKhorev avatar Apr 13 '24 15:04 AntonKhorev

There's overlap with #4455 here, though I think that actually already removes the down pointing arm?

tomhughes avatar Apr 14 '24 17:04 tomhughes

There's overlap with #4455 here, though I think that actually already removes the down pointing arm?

That is my understanding as well and I thing it would be better to focus on reviewing and merging #4455 and not add possible merge conflicts my cherry-picking changes.

tordans avatar Apr 14 '24 18:04 tordans

There's overlap with https://github.com/openstreetmap/openstreetmap-website/pull/4455 here

Of course there is, that's why I'm making this pull request. The third image in the PR description is from https://github.com/openstreetmap/openstreetmap-website/pull/4455 in dark mode.

it would be better to focus on reviewing and merging https://github.com/openstreetmap/openstreetmap-website/pull/4455 and not add possible merge conflicts

Or you can look at this PR as a thing that can be treated separately, a smaller part of https://github.com/openstreetmap/openstreetmap-website/pull/4455.

AntonKhorev avatar Apr 14 '24 23:04 AntonKhorev

This is still needed to remove the arm png.

AntonKhorev avatar May 06 '24 10:05 AntonKhorev

Presumably the SVG version can go as well?

What about the reference in common.scss though - is that redundant now?

tomhughes avatar May 06 '24 10:05 tomhughes

There's one svg file with both the entire globe and the arm layer. Editing that svg is tricky because it requires to have a specific font for 1's and 0's to look the same.

common.scss shouldn't have references to the arm image now.

AntonKhorev avatar May 06 '24 10:05 AntonKhorev

Ah yes my grep was a bit too generic.... Looks good then, thanks.

tomhughes avatar May 06 '24 11:05 tomhughes