openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

Accept coordinates with a slash in search

Open thibaultmol opened this issue 1 year ago • 7 comments

Problem

Currently if you put '52.47355/13.44108' in the search box, it won't realize you mean: "52.47355 13.44108"

Description

No response

Screenshots

No response

thibaultmol avatar Oct 11 '23 09:10 thibaultmol

Why would you do that though? Nobody write coordinates like that.

tomhughes avatar Oct 11 '23 09:10 tomhughes

Pretty much any url from a maps related website will write the coordinates in their url like that. It's surprisingly often that I copy coordinates from a url

thibaultmol avatar Oct 11 '23 09:10 thibaultmol

Well sure, and I often copy fragments from URLs to other places, but when I do so I understand that I am doing something odd and that I'm responsible for decoding the URL and converting it to an acceptable format for the place where I'm going to use it.

The vast majority of people will never do things like that though...

tomhughes avatar Oct 11 '23 09:10 tomhughes

I'm currently also manually removing the slash.

But I figured there was no harm in having it maybe be included in the search bar behavior

thibaultmol avatar Oct 11 '23 09:10 thibaultmol

Hi everyone @thibaultmol I am working on this issue

Please assign this issue to me is there any slack channel I can join, as I am new to this project

divyanshuagarwal-23 avatar Feb 03 '24 11:02 divyanshuagarwal-23

@divyanshuagarwal-23 Not every projects are working with bug assignments. Some are finding them even a bad thing: https://github.com/Microsoft/TypeScript/blob/main/CONTRIBUTING.md#issue-claiming https://devblogs.microsoft.com/oldnewthing/20091201-00/?p=15843

We have over 550 open issues. I would suggest reading all comments of one bug you are interested in and just go ahead learning this code base. If this results in a PR: great.

HolgerJeromin avatar Feb 03 '24 22:02 HolgerJeromin

This would have to be added here https://github.com/openstreetmap/openstreetmap-website/blob/master/app/controllers/geocoder_controller.rb#L209-L225 and test cases updated here https://github.com/openstreetmap/openstreetmap-website/blob/master/test/controllers/geocoder_controller_test.rb

mmd-osm avatar Jun 30 '24 11:06 mmd-osm