openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

Viewing user edit history does not show empty changesets

Open deevroman opened this issue 2 years ago • 6 comments

URL

https://www.openstreetmap.org/user/TrickyFoxy/history

How to reproduce the issue?

No response

Screenshot(s) or anything else?

OSMCha: Снимок экрана 2022-07-08 в 15 19 58 OSM website: Снимок экрана 2022-07-08 в 15 20 12

deevroman avatar Jul 08 '22 12:07 deevroman

That's probably deliberate because an empty changeset is not really very interesting.

tomhughes avatar Jul 08 '22 12:07 tomhughes

Indeed the starting condition for any changeset list conditions_nonempty from https://github.com/openstreetmap/openstreetmap-website/blob/master/app/controllers/changesets_controller.rb#L45,

tomhughes avatar Jul 08 '22 12:07 tomhughes

This is a strange solution: empty changeset is a sign of an error in the editor

deevroman avatar Jul 08 '22 12:07 deevroman

No, it is possible that the user wanted to upload a change (and the editor duly created a changeset) but then it turned out that the change could not be uploaded due to a conflict (someone else had modified the object in the mean time) and the user decides not to proceed. Other similar situations are possible and there is no way to "cancel" a changeset once opened.

woodpeck avatar Jul 08 '22 13:07 woodpeck

Actually judging by the comment the main purpose was to eliminate in process changesets that hadn't had any uploads yet.

tomhughes avatar Jul 08 '22 13:07 tomhughes

If there's a need to see these empty changesets, you can still use the OSM API: https://api.openstreetmap.org/api/0.6/changesets?display_name=TrickyFoxy

mmd-osm avatar Jul 08 '22 15:07 mmd-osm