openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

add öpnvkarte key/legend

Open swedneck opened this issue 4 years ago • 4 comments

this could use some more detail work to fill in missing zoom levels as well as road types, but it's most of the way finished.

swedneck avatar Aug 05 '21 22:08 swedneck

This causes a test failure:

Error:
SiteControllerTest#test_key:
ActionView::Template::Error: translation missing: en.site.key.table.entry.water
    app/views/site/key.html.erb:10
    app/views/site/key.html.erb:4:in `each'
    app/views/site/key.html.erb:4
    app/views/site/key.html.erb:3:in `each'
    app/views/site/key.html.erb:3
    app/controllers/site_controller.rb:50:in `key'
    config/initializers/compressed_requests.rb:27:in `call'
    config/initializers/cors.rb:9:in `call'
    test/controllers/site_controller_test.rb:169:in `test_key'

tomhughes avatar Aug 05 '21 23:08 tomhughes

that commit should fix the errors, i noticed that spaces need to be replaced with underscores, as well as a spelling error on light rail.

swedneck avatar Aug 06 '21 12:08 swedneck

No there's no need to add underscores to the image names - so long as the name of the name matched what you list in the configuration file you can use any name you like.

What you do need (and still don't have) is entries in the strings table (https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L2079) that match the names in your configuration file.

tomhughes avatar Aug 06 '21 16:08 tomhughes

oh i see how this works, thanks!

swedneck avatar Aug 08 '21 20:08 swedneck

@swedneck Are you planning to continue working on this?

matkoniecz avatar Oct 09 '22 15:10 matkoniecz

@matkoniecz i don't think so, unfortunately

swedneck avatar Oct 09 '22 16:10 swedneck

Can we close this as abandoned?

pnorman avatar Nov 24 '22 09:11 pnorman