openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

Improve Open Graph previews

Open lectrician1 opened this issue 5 years ago • 20 comments

Users on the OSM World Discord Server frequently post openstreetmap.org links to various areas they're talking about, changesets, etc.

Discord has embeds that use the Open Graph protocol to display rich data.

Currently the only embed data that's displayed looks like this: image A picture of the map for the linked area as <meta property="og:image"> included would be better.

or Screenshot 2020-11-15 at 7 36 12 PM A picture of the map and maybe a bit of changeset data would be better.

Now that I think about it, the embedded image request is probably not feasible. It would require the server generating a image and its link for every view of the map that is requested. However, all of the OSM layers use raster tiles so maybe this could be possible?

At least a better embed description is possible. As to what should be in each description should probably be discussed below.

lectrician1 avatar Nov 16 '20 01:11 lectrician1

When is this useful?

For example I would like my tests to run with output that shows passed tests, and never uses ansi. I would like to be able to set those settings in my repo, and version them and have them automatically picked up for any test run.

nohwnd avatar Aug 15 '24 11:08 nohwnd

Thanks @nohwnd!

I find it useful indeed but I think I would prefer this behavior to not be part of the core platform so it remains 100% deterministic.

I am wondering if this could be an added feature of VS and dotnet test (could be some kind of shared library or an extension) that does the lookup and force the --settings path to the call. This means we would have a different UX when calling the exe directly but I think it's fine.

Evangelink avatar Aug 15 '24 11:08 Evangelink

Actually as runsettings are coming from the bridge, it's probably find to say the lookup feature is provided by the bridge.

Evangelink avatar Aug 15 '24 11:08 Evangelink

It does not have to be runsettings specifically, I would much rather have it built in for some configuration that the platform is able to consume. I don't think runsettings should be used in the future as the way to configure test runs.

nohwnd avatar Aug 15 '24 12:08 nohwnd

I would much rather have it built in for some configuration that the platform

See related ticket.

Evangelink avatar Aug 15 '24 12:08 Evangelink

Is this the same as #3499 ?

thomhurst avatar Aug 15 '24 12:08 thomhurst

Partially, this ticket is about how to find the configuration file (similarly to #3562). Yours is asking about the support of command line options in the config file.

BTW you could already have a look at https://github.com/microsoft/testfx/blob/main/docs/testingplatform/configuration.md to start adding your settings in this file. We will be releasing 1.4 preview today (please use this version if you want to do so).

Evangelink avatar Aug 15 '24 12:08 Evangelink