openstreetmap-website icon indicating copy to clipboard operation
openstreetmap-website copied to clipboard

Add link to my messages to users/show navigation

Open tordans opened this issue 5 years ago • 6 comments

The my messages page can be accessed via the user dropdown, but not via the user navigation on my logged in user-profile page. This adds the link when logged in to have a consistent access to all my sub-pages.

Current header

Bildschirmfoto 2019-09-22 um 19 47 49

New header

Bildschirmfoto 2019-09-22 um 19 47 57

Open questions

  • [ ] The new navi uses the same translation string as the dropdown (as do all those links). The german translation for the .my messages only says "Nachrichten" (EN: Messages). This is consistent in the dropdown, but not on the user-page. Suggestion: Duplicate the translations in all languages so the dropdown can have it's own variation. Right now the dropdown forces the translation with <%= t("users.show.my messages") %>

tordans avatar Sep 22 '19 17:09 tordans

I think we're fairly reluctant to add more things to that line to be honest - it's already far too long really.

tomhughes avatar Sep 22 '19 23:09 tomhughes

For me, the simplicity of the UI is less in the count of elements but more in finding the elements where I expect them. I expect my messages to be part of the my-* links. I find myself confused about what I find in the dropdown and what in the user profile navigation.

tordans avatar Sep 29 '19 18:09 tordans

Been pondering this. Maybe the profile page should have a second navigation element, maybe a second strip of links to include "My messages", "My Settings", and "Logout" (doubling up on links available in the top-right drop-down). Bit cluttering maybe, but it would be a rationalisation since "My settings" is an odd one out at the moment. It's the only one currently doubled-up. It's also the only one which is not a list of things which form part of the profile.

A related problem: when viewing somebody else's profile this same strip of links contains "lists of things which form part of the profile" mixed with three actions. So here again a second strip of links might make it tidier.

harry-wood avatar Apr 04 '21 01:04 harry-wood

Maybe the profile page should have a second navigation element, maybe a second strip of links

I think a better a

gravitystorm avatar Apr 07 '21 16:04 gravitystorm

I think a better a

It looks like this message was cut off

pnorman avatar Apr 07 '21 22:04 pnorman

I honestly can't remember what I was writing here, nor why I closed the pull request - so reopening seems like the best bet.

gravitystorm avatar Apr 29 '21 09:04 gravitystorm